Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118660
MIME-Version: 1.0
Date: Mon, 19 Sep 2022 21:04:07 +0200
Message-ID: <CAJpLVh3pUhOZyMue96qEP417Qx5Aj22dmAP5=SwQkeVUzVNAQg@mail.gmail.com>
To: internals@lists.php.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] One-line heredoc for better syntax highlightning
From: olleharstedt@gmail.com (=?UTF-8?Q?Olle_H=C3=A4rstedt?=)

> I don't find that example particularly readable or convincing. It mushes
> together PHP and MySQL keywords too much.
>
> Once you add a WHERE clause that SQL query should be split across
> multiple multiple lines for readability anyway and even for that very
> simple example I personally would add a linebreak in front of the FROM:
>
> $query =3D <<<MySQL
> SELECT *
> FROM foo
> MySQL;
>
> Best regards
>Tim D=C3=BCsterhus

That looks good in isolation, but consider the following short snippet:

class Foo
{
    public function bar()
    {
        $query =3D <<<MySQL
        SELECT * FROM baz
MySQL;
    }
}

As you can see, the heredoc breaks the reading flow completely. For
smaller SQL queries, using one line would be an improvement, I think.

Also consider that the one line will look better in your color
highlight editor. :)

Olle