Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118595
Message-ID: <1315d105-7ab7-74da-888a-b7b023cd0c27@bastelstu.be>
Date: Sat, 10 Sep 2022 13:46:05 +0200
MIME-Version: 1.0
Content-Language: en-US
To: Paul Dragoonis <dragoonis@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
References: <530b3a9d-0ee4-6061-8c69-df672d238032@bastelstu.be>
 <628f27cd-d7f0-4a75-bf5b-f4812ff459a5@www.fastmail.com>
 <2474d6fc-a61d-19e8-b903-ff389dbb9ff6@bastelstu.be>
 <de7c9a48-6ffb-4b48-831b-00f1a24cd7af@www.fastmail.com>
 <e2d62544-2b2e-d67f-5452-187971a56068@bastelstu.be>
 <CAKxcST86H6hRCemQvB5QfPsi0GZnmOZ_j+d_WN1NVVF=qDy21A@mail.gmail.com>
In-Reply-To: <CAKxcST86H6hRCemQvB5QfPsi0GZnmOZ_j+d_WN1NVVF=qDy21A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] RFC [Discussion]: Improve unserialize() error handling
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 9/10/22 13:03, Paul Dragoonis wrote:
> Do give it more thought regarding the callbacks what Nikolas said, sleep on
> it.

Are you referring to 'unserialize_callback_func' or to the unserialize 
handlers (i.e. __wakeup, __unserialize, Serializable::unserialize)?

If the former, I am currently waiting for an explanation of the use 
cases from someone who uses it, to be able to make an educated decision.

> Not saying it matters, but also double check how error handling MAY differ
> when in a Class::_unserialize() context. Maybe it doesn't diff, I haven't
> checked in a while, but food for thought.

I'm afraid, this is a little vague. What possible difference (and 
difference to *what*) do you have in mind?

> In any case, good cleanup initiative.
>
Best regards
Tim Düsterhus