Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118594
MIME-Version: 1.0
References: <530b3a9d-0ee4-6061-8c69-df672d238032@bastelstu.be>
 <628f27cd-d7f0-4a75-bf5b-f4812ff459a5@www.fastmail.com> <2474d6fc-a61d-19e8-b903-ff389dbb9ff6@bastelstu.be>
 <de7c9a48-6ffb-4b48-831b-00f1a24cd7af@www.fastmail.com> <e2d62544-2b2e-d67f-5452-187971a56068@bastelstu.be>
In-Reply-To: <e2d62544-2b2e-d67f-5452-187971a56068@bastelstu.be>
Date: Sat, 10 Sep 2022 12:03:54 +0100
Message-ID: <CAKxcST86H6hRCemQvB5QfPsi0GZnmOZ_j+d_WN1NVVF=qDy21A@mail.gmail.com>
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000d279ce05e8509e2a"
Subject: Re: [PHP-DEV] RFC [Discussion]: Improve unserialize() error handling
From: dragoonis@gmail.com (Paul Dragoonis)

--000000000000d279ce05e8509e2a
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 8 Sep 2022, 17:18 Tim D=C3=BCsterhus, <tim@bastelstu.be> wrote:

> Hi
>
> On 9/7/22 23:44, Larry Garfield wrote:
> > Either I guess?  Honestly we should decide that in advance on the list.
> :-)  E_WARNING+Exception in 9 is what I'd probably favor, with "Exception
> now" as a second choice.
> >
>
> I'm a new-ish contributor here in internals, so I don't know how things
> were done in the past for similar situations/issues.
>

Welcome, Tim :-)

Do give it more thought regarding the callbacks what Nikolas said, sleep on
it.

Not saying it matters, but also double check how error handling MAY differ
when in a Class::_unserialize() context. Maybe it doesn't diff, I haven't
checked in a while, but food for thought.

In any case, good cleanup initiative.


> I'm not sure, though if it makes sense to already decide on something
> for PHP 9. If it's not baked into code shortly after the vote finishes,
> then people might forget that "there's something that still needs to be
> done". For a deprecation one can at least go through all the
> deprecations once PHP 9 opens, as a deprecation effectively is defined
> to be a removal in the next major. For a warning this is less obvious.
>
> Personally my first choice would be "Straight to Exception", so I might
> not be the best person to decide on that :-)
>
> Best regards
> Tim D=C3=BCsterhus
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>
>

--000000000000d279ce05e8509e2a--