Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118590
MIME-Version: 1.0
References: <CABiw4UhL6NTD+iPPY=9qwN5-bKABkLxgrPDA2awO171Txi1-eQ@mail.gmail.com>
 <60350e90-3f2a-df6b-fd56-ab6613a610eb@gmx.de> <CAEKnhAG4zotAKwa++nTdH9r3QOi95_6Dw57bCKN-hRo_AXc45w@mail.gmail.com>
 <b4e309e0-3630-a25f-f618-3f194e0f3248@heigl.org> <29478c19-db71-55b5-d57d-aad2bfbd1fb0@gmx.de>
In-Reply-To: <29478c19-db71-55b5-d57d-aad2bfbd1fb0@gmx.de>
Date: Fri, 9 Sep 2022 22:38:39 +0100
Message-ID: <CAKxcST-MpEdBu1Gx8qMJ3QUb_7QrX0JFRVua5eZvuYm04j=Pmg@mail.gmail.com>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: Andreas Heigl <andreas@heigl.org>, PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000007a74505e8455f6e"
Subject: Re: [PHP-DEV] Re: Increase maximum size of an uploaded file to 50Mbyte
From: dragoonis@gmail.com (Paul Dragoonis)

--00000000000007a74505e8455f6e
Content-Type: text/plain; charset="UTF-8"

On Thu, 8 Sep 2022, 12:59 Christoph M. Becker, <cmbecker69@gmx.de> wrote:

> On 08.09.2022 at 13:01, Andreas Heigl wrote:
>
> > On 08.09.22 12:35, Jakub Zelenka wrote:
> >
> >> On Wed, Sep 7, 2022 at 3:28 PM Christoph M. Becker <cmbecker69@gmx.de>
> >> wrote:
> >>
> >>> On 07.09.2022 at 15:57, Misha wrote:
> >>>
> >>>> We spend a lot of time to increase limits for uploads file in PHP.
> >>>> Can we
> >>>> increase it in php.ini?
> >>>>
> >>>> Current value is 2Mb. Its so small value, when photo image can take
> 8Mb
> >>> on
> >>>> iPhone X.
> >>>> We should increase it to 50Mb, because DevOps engineers do useless
> work
> >>>> trying to change it.
> >>>>
> >>>> I have prepared PR for it https://github.com/php/php-src/pull/9315
> >>>
> >>> I'm not against increasing the sizes, but 50MB might be too much.
> >>>
> >>> Anyway, only changing the php.ini files doesn't make sense in my
> >>> opinion, since they're probably only used on Windows, and they should
> >>> reflect the actual default values[1].
> >>
> >>   It's true that those particular ini files are not directly used on
> >> Linux
> >> but distros often base their changes on them and the distro provided
> ones
> >> are actually used. So it means that main defaults in main.c are most
> >> likely
> >> not used. Although I agree they should be changed too so it is
> >> consistent.
> >
> > No matter which value we preset, it will most certainly not be adequate.
> >
> > So people *will* have to set it according to their needs. And if they
> > didn't so far, then they are happy with the current setting.
> >
> > Don't get me wrong: I'm not against changing that value.
> >
> > But is it really an issue that needs solving? It's a default value of a
> > configuration file. When I'm unhappy with the default, I change it to a
> > more suitable value. When I'm not able to do that... perhaps I should
> > leave my fingers not only from the config file...
>
> It might be worth to point out that we're using these defaults since PHP
> 4.0 (at least), so reconsidering sensible defaults might be appropriate.
>


I can sense we are all feeling like upping the value here.

If we take it slow and move from 2MB to 8MB that would ease into it, and
see how it goes in our next release ?

Do we RFC this? Who is volunteering to make it, if so? :-)



> --
> Christoph M. Becker
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>
>

--00000000000007a74505e8455f6e--