Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118587
Feedback-ID: i8414410d:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-927-gf4c98c8499-fm-20220826.002-gf4c98c84
Mime-Version: 1.0
Message-ID: <d27551ce-78da-49b1-8531-41c2d5e97036@www.fastmail.com>
In-Reply-To: <e2d62544-2b2e-d67f-5452-187971a56068@bastelstu.be>
References: <530b3a9d-0ee4-6061-8c69-df672d238032@bastelstu.be>
 <628f27cd-d7f0-4a75-bf5b-f4812ff459a5@www.fastmail.com>
 <2474d6fc-a61d-19e8-b903-ff389dbb9ff6@bastelstu.be>
 <de7c9a48-6ffb-4b48-831b-00f1a24cd7af@www.fastmail.com>
 <e2d62544-2b2e-d67f-5452-187971a56068@bastelstu.be>
Date: Thu, 08 Sep 2022 11:36:07 -0500
To: "php internals" <internals@lists.php.net>
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] RFC [Discussion]: Improve unserialize() error handling
From: larry@garfieldtech.com ("Larry Garfield")

On Thu, Sep 8, 2022, at 11:18 AM, Tim D=C3=BCsterhus wrote:
> Hi
>
> On 9/7/22 23:44, Larry Garfield wrote:
>> Either I guess?  Honestly we should decide that in advance on the lis=
t. :-)  E_WARNING+Exception in 9 is what I'd probably favor, with "Excep=
tion now" as a second choice.
>>=20
>
> I'm a new-ish contributor here in internals, so I don't know how thing=
s=20
> were done in the past for similar situations/issues.
>
> I'm not sure, though if it makes sense to already decide on something=20
> for PHP 9. If it's not baked into code shortly after the vote finishes=
,=20
> then people might forget that "there's something that still needs to b=
e=20
> done". For a deprecation one can at least go through all the=20
> deprecations once PHP 9 opens, as a deprecation effectively is defined=20
> to be a removal in the next major. For a warning this is less obvious.
>
> Personally my first choice would be "Straight to Exception", so I migh=
t=20
> not be the best person to decide on that :-)
>
> Best regards
> Tim D=C3=BCsterhus

We've done this kind of two-step thing before; a lot of PHP 8 changes we=
re voted on well in advance of 8.0's release.  A "Warning now, Exception=
 in 9" vote would not be unprecedented.

--Larry Garfield