Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118586
Message-ID: <e2d62544-2b2e-d67f-5452-187971a56068@bastelstu.be>
Date: Thu, 8 Sep 2022 18:18:06 +0200
MIME-Version: 1.0
Content-Language: en-US
To: internals@lists.php.net
References: <530b3a9d-0ee4-6061-8c69-df672d238032@bastelstu.be>
 <628f27cd-d7f0-4a75-bf5b-f4812ff459a5@www.fastmail.com>
 <2474d6fc-a61d-19e8-b903-ff389dbb9ff6@bastelstu.be>
 <de7c9a48-6ffb-4b48-831b-00f1a24cd7af@www.fastmail.com>
In-Reply-To: <de7c9a48-6ffb-4b48-831b-00f1a24cd7af@www.fastmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] RFC [Discussion]: Improve unserialize() error handling
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 9/7/22 23:44, Larry Garfield wrote:
> Either I guess?  Honestly we should decide that in advance on the list. :-)  E_WARNING+Exception in 9 is what I'd probably favor, with "Exception now" as a second choice.
> 

I'm a new-ish contributor here in internals, so I don't know how things 
were done in the past for similar situations/issues.

I'm not sure, though if it makes sense to already decide on something 
for PHP 9. If it's not baked into code shortly after the vote finishes, 
then people might forget that "there's something that still needs to be 
done". For a deprecation one can at least go through all the 
deprecations once PHP 9 opens, as a deprecation effectively is defined 
to be a removal in the next major. For a warning this is less obvious.

Personally my first choice would be "Straight to Exception", so I might 
not be the best person to decide on that :-)

Best regards
Tim Düsterhus