Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118574
Return-Path: <tim@bastelstu.be>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 23312 invoked from network); 7 Sep 2022 15:37:09 -0000
Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5)
  by pb1.pair.com with SMTP; 7 Sep 2022 15:37:09 -0000
Received: from php-smtp4.php.net (localhost [127.0.0.1])
	by php-smtp4.php.net (Postfix) with ESMTP id E6F52180084
	for <internals@lists.php.net>; Wed,  7 Sep 2022 08:37:08 -0700 (PDT)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net
X-Spam-Level: 
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,
	T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2
X-Spam-ASN: AS24940 176.9.0.0/16
X-Spam-Virus: No
X-Envelope-From: <tim@bastelstu.be>
Received: from chrono.xqk7.com (chrono.xqk7.com [176.9.45.72])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by php-smtp4.php.net (Postfix) with ESMTPS
	for <internals@lists.php.net>; Wed,  7 Sep 2022 08:37:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bastelstu.be;
	s=mail20171119; t=1662565027;
	bh=3lqE/1CTGRFVWO+gRpm4NXL2GYAZK9jlm6lg6YsLcVw=;
	h=Date:Subject:To:References:From:In-Reply-To:From;
	b=J38bDP2ZMz6FWUUKIHHKoMXTF6ofPt3QqJhyvzGLjoJlQB94bwJDNdE5sW9/gdpz1
	 JvLcNPzuv6xGMWwhkwi8Iunc1/1WTlFPVaYiym1YM5yq5pcZmqC667cP5GcEPz9h38
	 dEbWEz4LNmc8qOcmGsjyYlepnj8SUBGwBGne193rFUfXXqPkmOYylxUcU/ZcKOHq9D
	 0ajjlGmMJDclqe5qApCHvpSMVUwjRiM5GSnv6RiWsxZKFi8OXFL3UcdfTpuA5qmbpu
	 Vy3TcDjP3mD9g746R58Gem1USxJbJL0kIli5jq/JsTOtz75iE7btCXWtAOOsFG33u9
	 1kK8BNfySnZ1Q==
Message-ID: <2474d6fc-a61d-19e8-b903-ff389dbb9ff6@bastelstu.be>
Date: Wed, 7 Sep 2022 17:37:07 +0200
MIME-Version: 1.0
Content-Language: en-US
To: internals@lists.php.net
References: <530b3a9d-0ee4-6061-8c69-df672d238032@bastelstu.be>
 <628f27cd-d7f0-4a75-bf5b-f4812ff459a5@www.fastmail.com>
In-Reply-To: <628f27cd-d7f0-4a75-bf5b-f4812ff459a5@www.fastmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] RFC [Discussion]: Improve unserialize() error handling
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 9/5/22 23:12, Larry Garfield wrote:
>> RFC: Improve unserialize() error handling
>> https://wiki.php.net/rfc/improve_unserialize_error_handling
>>
> Well-explained and well-argued.  The only thing I'd add is that we should consider bumping the E_NOTICE to an E_WARNING, *and* slating it to increase to an exception in 9.0.  This feels like a smaller BC concern than most, but people are extra sensitive these days about those edge cases so it's probably good to be cautious.

Can you please clarify whether you mean:

1. Change the existing E_WARNING option to "E_WARNING+Exception in 9.0".
2. Add a new "E_WARNING+Exception in 9.0" option the vote, such that the 
vote will be "E_WARNING" vs "E_WARNING+Exception in 9.0" vs "Exception"

Best regards
Tim Düsterhus