Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118573
Message-ID: <51f97d1a-7fb0-a97c-daa2-71e82d603f0c@bastelstu.be>
Date: Wed, 7 Sep 2022 17:35:13 +0200
MIME-Version: 1.0
Content-Language: en-US
To: internals@lists.php.net
References: <530b3a9d-0ee4-6061-8c69-df672d238032@bastelstu.be>
 <2252734.ElGaqSPkdT@come-prox15amd>
In-Reply-To: <2252734.ElGaqSPkdT@come-prox15amd>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] RFC [Discussion]: Improve unserialize() error handling
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 9/7/22 14:41, Côme Chilliet wrote:
> Le lundi 5 septembre 2022, 19:20:00 CEST Tim Düsterhus a écrit :
>> RFC: Improve unserialize() error handling
>> https://wiki.php.net/rfc/improve_unserialize_error_handling
> 
> Is the new UnserializationFailedException class extending any other Exception
> class ? This is not explained in the RFC.

Yes, it necessarily extends another exception class, because \Throwable 
may only be implemented by \Exception and \Error.

\UnserializationFailedException is a direct child of \Exception:

1. Making it part of the \Error hierarchy was argued against in this 
comment: https://github.com/php/php-src/pull/9185#issuecomment-1199580418

2. Using a different parent class does not bring any benefit, because 
the intended use is to specifically 
catch(\UnserializationFailedException) and not to catch it together with 
unrelated stuff.

I've also added a code block to the RFC that shows the full (and 
trivial) implementation of the \UnserializationFailedException.

Best regards
Tim Düsterhus