Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118566
Message-ID: <530b3a9d-0ee4-6061-8c69-df672d238032@bastelstu.be>
Date: Mon, 5 Sep 2022 19:20:00 +0200
MIME-Version: 1.0
Content-Language: en-US
To: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: RFC [Discussion]: Improve unserialize() error handling
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

I've now written up an RFC as a follow-up for the "What type of 
Exception to use for unserialize() failure?" thread [1]:

----

RFC: Improve unserialize() error handling
https://wiki.php.net/rfc/improve_unserialize_error_handling

Proof of concept implementation is in:

https://github.com/php/php-src/pull/9425

Discussion period for that RFC is officially opened up.

----

The primary point of discussion in the previous mailing list thread and 
in the PR comments is whether unserialize() should continue to emit 
E_WARNING or whether that should consistently be changed to an 
Exception. As of now I plan to explicitly vote on this and the RFC 
contains some opinions on that matter.

Best regards
Tim Düsterhus

[1] https://externals.io/message/118311