Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118547
MIME-Version: 1.0
References: <00d044c6-8059-3487-ca3a-7881d4ca462a@gmx.de> <CAESVnVq9TOL4Tj57N5s46=hbTb9-uHYZUAN_LYhv1n2yEdTdNA@mail.gmail.com>
In-Reply-To: <CAESVnVq9TOL4Tj57N5s46=hbTb9-uHYZUAN_LYhv1n2yEdTdNA@mail.gmail.com>
Date: Wed, 31 Aug 2022 23:13:31 +0200
Message-ID: <CAJmy8YFS4CEik7D-FN=H9Ee2KSNB+poMMu9jcYSy4r-Wz=E6jw@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Cc: "Christoph M. Becker" <cmbecker69@gmx.de>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000121c1b05e78ff94d"
Subject: Re: [PHP-DEV] No longer allow block mode for declare(encoding)
From: divinity76@gmail.com (Hans Henrik Bergan)

--000000000000121c1b05e78ff94d
Content-Type: text/plain; charset="UTF-8"

>it might be hard to properly implement support

No effort should be wasted supporting this.
+1

On Wed, Aug 31, 2022, 21:21 Sara Golemon <pollita@php.net> wrote:

> On Wed, Aug 31, 2022 at 10:43 AM Christoph M. Becker <cmbecker69@gmx.de>
> wrote:
>
> > recently, there was a bug report regarding declare(encoding)[1].  I've
> > checked that, and found that the current implementation of
> > declare(encoding) doesn't make sense regarding "block mode", since this
> > is completely ignored; instead, each (allowed) declare(encoding) works
> > from where it is written till the next declare(encoding) (well, probably
> > more or less).
> >
> > Since I consider switching the character encoding in the middle of a
> > file not reasonable (and it might be hard to properly implement support
> > for that), I suggest to disallow block mode for declare(encoding) as of
> > PHP 8.3.  A respective PR is available[2].
> >
> >
> I think I can imagine scenarios where switching encodings within a file
> would.... work?  Especially for ASCII transparent encodings...  That said,
> if you're currently depending on multiple encodings in a single file then
> you probably deserve whatever you get.
>
> +1
>
> -Sara
>

--000000000000121c1b05e78ff94d--