Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118545
MIME-Version: 1.0
References: <00d044c6-8059-3487-ca3a-7881d4ca462a@gmx.de>
In-Reply-To: <00d044c6-8059-3487-ca3a-7881d4ca462a@gmx.de>
Date: Wed, 31 Aug 2022 14:20:51 -0500
Message-ID: <CAESVnVq9TOL4Tj57N5s46=hbTb9-uHYZUAN_LYhv1n2yEdTdNA@mail.gmail.com>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000b78c3105e78e65dc"
Subject: Re: [PHP-DEV] No longer allow block mode for declare(encoding)
From: pollita@php.net (Sara Golemon)

--000000000000b78c3105e78e65dc
Content-Type: text/plain; charset="UTF-8"

On Wed, Aug 31, 2022 at 10:43 AM Christoph M. Becker <cmbecker69@gmx.de>
wrote:

> recently, there was a bug report regarding declare(encoding)[1].  I've
> checked that, and found that the current implementation of
> declare(encoding) doesn't make sense regarding "block mode", since this
> is completely ignored; instead, each (allowed) declare(encoding) works
> from where it is written till the next declare(encoding) (well, probably
> more or less).
>
> Since I consider switching the character encoding in the middle of a
> file not reasonable (and it might be hard to properly implement support
> for that), I suggest to disallow block mode for declare(encoding) as of
> PHP 8.3.  A respective PR is available[2].
>
>
I think I can imagine scenarios where switching encodings within a file
would.... work?  Especially for ASCII transparent encodings...  That said,
if you're currently depending on multiple encodings in a single file then
you probably deserve whatever you get.

+1

-Sara

--000000000000b78c3105e78e65dc--