Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118537
MIME-Version: 1.0
References: <CANMwmbN8_Km+urXbNO7oWvNteYA2mTPNYyRgfaoypEK1Cw4F0A@mail.gmail.com>
 <CA+p1FaZDm3-h_LoOwv619wFyPg+2pAM8qC2La438sU_SPHZnCg@mail.gmail.com>
 <CABdc3WqsDc+80ATdX9+qstOkf+eUYCAQNPeV_FXcHiFumVQb8A@mail.gmail.com>
 <8D53AD5B-7CFC-4820-9EE4-FEB365D327A8@woofle.net> <CABdc3Wo7_qJOtebvA2GNGFUGFAut3tJOShXDBLHnRKqhrwVJ-g@mail.gmail.com>
 <d2f2c96c-3d45-49fc-ad0b-16e5a578891c@www.fastmail.com> <CAGBsUrcVmKRz=X8B1pVxavh1WE3aYTOMEbiWeYqTgky67atAdw@mail.gmail.com>
 <CA+p1FaZF8C12xn7q7r+1SGVHKca-+KWrv0WB1X-fSawnDz07GQ@mail.gmail.com>
 <CANLbj-rfHh9T84WJxcXW3nSj44mmXdDHT_XDM26WWKbiJKvJxw@mail.gmail.com>
 <afe236de-e35f-487a-93a6-250efc0f3f9d@www.fastmail.com> <CANMwmbOZNBR0gog0V_UH7LDL9JPNpsEmhQKrEmBFhxu-nR6T_w@mail.gmail.com>
 <CANMwmbOs5EPg5wOv1ULy+DEGr3mrwN4R8COMmrwMdCtWF36nPw@mail.gmail.com>
 <CANMwmbNw8ovHyXVL5dQg9ea8X4KcHrpHxgw2Q9fCn_vjiTx5eA@mail.gmail.com>
 <CA+p1FaY6N5E_g6LFNTbd7eZk4DoYVsg15ZcoYjLJi=DutinD-g@mail.gmail.com>
 <CANMwmbPmmn0CAK0QGg+KX7qfoCq1SsWfM8fM0556rwMMXNQ4FQ@mail.gmail.com>
 <CANMwmbPMO4X1_nobeVX-5qkM1B8P=+byygf8=HmC1hZSafXD9w@mail.gmail.com>
 <CADK1yXJihGBHSJAT8v7g3PAoy2x9h=4Jx0yUq8gaocz495WEYw@mail.gmail.com>
 <CANMwmbOTzTU7mkN3csFNw4BJxMJ8-gW8HZmYut1g8jZ0UQh7Hw@mail.gmail.com> <CADK1yXJGySdbUHfg=d6yiqJmr3aywQ0otfvf8Vc8RH87XHZPjw@mail.gmail.com>
In-Reply-To: <CADK1yXJGySdbUHfg=d6yiqJmr3aywQ0otfvf8Vc8RH87XHZPjw@mail.gmail.com>
Date: Mon, 29 Aug 2022 11:42:56 +0200
Message-ID: <CANMwmbOZUorCzTDYvAh+hHQFz=OjHkqbTvp1ZRGTtk=A2MkWtQ@mail.gmail.com>
To: Deleu <deleugyn@gmail.com>, PHP Internals List <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] RFC json_validate() - status: Under Discussion
From: dev.juan.morales@gmail.com (juan carlos morales)

El lun, 29 ago 2022 a las 11:26, Deleu (<deleugyn@gmail.com>) escribi=C3=B3=
:
>
>
>
> On Mon, Aug 29, 2022 at 11:19 AM juan carlos morales <dev.juan.morales@gm=
ail.com> wrote:
>>
>> El lun, 29 ago 2022 a las 11:06, Deleu (<deleugyn@gmail.com>) escribi=C3=
=B3:
>> >
>> > Has the option of returning a Result object been discussed/considered?=
 Can it be an option? I imagine that if `json_validate(): JsonValidationRes=
ult` always returns a `JsonValidationResult` which contains a `public reado=
nly bool $valid` and a `public readonly ?string $error` it would be better =
than both options on the table right now. The option of returning CLI-like =
results means that we will need a `if (! json_validate())` to treat a valid=
 JSON (really awkward) and the option of using `json_last_error()` relies o=
n an internal state instead of an immutable structure. Effectively, what we=
 need is to return a complex structure which can contain a boolean and a st=
ring and that is a class/object.
>> >
>> Interesting, it was not considered.
>>
>> I still think BOOLEAN is my preferred choice, but can you provide an
>> example about how the code would look like with your approach? Imagine
>> you have the feature like in your suggestion ... how a developer would
>> write the code?
>
>
> ```
> $json =3D '{}';
>
> $result =3D json_validate($json);
>
> if (! $result->valid) {
>     throw new \Exception('Invalid JSON provided: ' . $result->error);
> }
>
> $something->saveUserProvidedJson($json);
> ```
>
> --
> Marco Deleu

Thanks for participating on the discussion and I will take note about
this also, but ...
Quick question: Is in PHP some rule, norma, estandard about "result
objects" already? (like, "should have these methods, and implement
this interface, etc.)

FYI: Just want to clarify that there is nothing bad/wrong about
relying on "internal state" by calling json_last_error(), as this
pattern is used not only by json_decode() but also mysqli extension
for example, among others. Nothing wrong honeslty IMO.

RFC: https://wiki.php.net/rfc/json_validate
Implementation: https://github.com/php/php-src/pull/9399