Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118535
MIME-Version: 1.0
References: <CANMwmbN8_Km+urXbNO7oWvNteYA2mTPNYyRgfaoypEK1Cw4F0A@mail.gmail.com>
 <CA+p1FaZDm3-h_LoOwv619wFyPg+2pAM8qC2La438sU_SPHZnCg@mail.gmail.com>
 <CABdc3WqsDc+80ATdX9+qstOkf+eUYCAQNPeV_FXcHiFumVQb8A@mail.gmail.com>
 <8D53AD5B-7CFC-4820-9EE4-FEB365D327A8@woofle.net> <CABdc3Wo7_qJOtebvA2GNGFUGFAut3tJOShXDBLHnRKqhrwVJ-g@mail.gmail.com>
 <d2f2c96c-3d45-49fc-ad0b-16e5a578891c@www.fastmail.com> <CAGBsUrcVmKRz=X8B1pVxavh1WE3aYTOMEbiWeYqTgky67atAdw@mail.gmail.com>
 <CA+p1FaZF8C12xn7q7r+1SGVHKca-+KWrv0WB1X-fSawnDz07GQ@mail.gmail.com>
 <CANLbj-rfHh9T84WJxcXW3nSj44mmXdDHT_XDM26WWKbiJKvJxw@mail.gmail.com>
 <afe236de-e35f-487a-93a6-250efc0f3f9d@www.fastmail.com> <CANMwmbOZNBR0gog0V_UH7LDL9JPNpsEmhQKrEmBFhxu-nR6T_w@mail.gmail.com>
 <CANMwmbOs5EPg5wOv1ULy+DEGr3mrwN4R8COMmrwMdCtWF36nPw@mail.gmail.com>
 <CANMwmbNw8ovHyXVL5dQg9ea8X4KcHrpHxgw2Q9fCn_vjiTx5eA@mail.gmail.com>
 <CA+p1FaY6N5E_g6LFNTbd7eZk4DoYVsg15ZcoYjLJi=DutinD-g@mail.gmail.com>
 <CANMwmbPmmn0CAK0QGg+KX7qfoCq1SsWfM8fM0556rwMMXNQ4FQ@mail.gmail.com> <CANMwmbPMO4X1_nobeVX-5qkM1B8P=+byygf8=HmC1hZSafXD9w@mail.gmail.com>
In-Reply-To: <CANMwmbPMO4X1_nobeVX-5qkM1B8P=+byygf8=HmC1hZSafXD9w@mail.gmail.com>
Date: Mon, 29 Aug 2022 11:05:31 +0200
Message-ID: <CADK1yXJihGBHSJAT8v7g3PAoy2x9h=4Jx0yUq8gaocz495WEYw@mail.gmail.com>
To: juan carlos morales <dev.juan.morales@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000fdbc3c05e75d9271"
Subject: Re: [PHP-DEV] RFC json_validate() - status: Under Discussion
From: deleugyn@gmail.com (Deleu)

--000000000000fdbc3c05e75d9271
Content-Type: text/plain; charset="UTF-8"

On Mon, Aug 29, 2022 at 10:50 AM juan carlos morales <
dev.juan.morales@gmail.com> wrote:

> There is still 1 open question on the RFC, and is about the return value.
>
> https://wiki.php.net/rfc/json_validate#open_issuesquestions
>
> I would appreciate your feedback on this. Even though I was told the
> RFC can go with 2 votings, I would like to know your thoughts about
> that open question, in short, the return value.
>

Has the option of returning a Result object been discussed/considered? Can
it be an option? I imagine that if `json_validate(): JsonValidationResult`
always returns a `JsonValidationResult` which contains a `public readonly
bool $valid` and a `public readonly ?string $error` it would be better than
both options on the table right now. The option of returning CLI-like
results means that we will need a `if (! json_validate())` to treat a valid
JSON (really awkward) and the option of using `json_last_error()` relies on
an internal state instead of an immutable structure. Effectively, what we
need is to return a complex structure which can contain a boolean and a
string and that is a class/object.

Thoughts?

-- 
Marco Deleu

--000000000000fdbc3c05e75d9271--