Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:118534 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 29536 invoked from network); 29 Aug 2022 08:50:24 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 29 Aug 2022 08:50:24 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id E4C4F1804A9 for ; Mon, 29 Aug 2022 01:50:20 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_05,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-vk1-f182.google.com (mail-vk1-f182.google.com [209.85.221.182]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Mon, 29 Aug 2022 01:50:20 -0700 (PDT) Received: by mail-vk1-f182.google.com with SMTP id t82so1229787vkb.6 for ; Mon, 29 Aug 2022 01:50:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc; bh=t6DEXYYSeZs3AUcU9KgOQKt10c9QwLuGjbi1+AVeCH8=; b=YaTV0N4XFwbbxdtXH+8GcOzDzK2QMwH1wRMZThMjD1jhoJukivZuQDpgtp4+Ha64MQ +r62uzbM6Mrt3U4agw7PWlvadG2tHKVaxW4phIl0TfbMyEqVhVuSxNVr0K/ZCD9YadOW BMxk/ED9+4PvQpNpuJ2I50OgEC+YAQQWVEqVJaFDc0oQ9+UuuACCztBkHZL93gA4rYG4 hXSwIx7jrTep8Ghmpu27qbOgTL2ie6oPR0eUyCZ2K2pTDlEr9zay59KSdaQBdC0/ma5W DuJoH17ef0Rw+gqoeZqqX66P7L56JJfUmlA/Mb333VNFDVWbc2XioXz7sNI2Pp0VHfBl r/KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc; bh=t6DEXYYSeZs3AUcU9KgOQKt10c9QwLuGjbi1+AVeCH8=; b=RdvOcKdh/NagO1tnbahp/sfp9sp87nh1rz6jNuDkp+8U8zMyBSuqgicDaSZ0cfjox7 dw9RZguzCloO09S8wfbltXIo8rt/HyzKt4kVpPTAKaw2/pdB59vi9Ibn11ztSx6qF5ht cZVTDFKXyOzXmJUWer9b94JpHEw9pBwKh7cMvyMHCZCdqfsDRFCa+JQQALx9SRl/yiex b8UYGCTx+NX+eXyzCojOIPwHbdTEqtmYF2A+jTocBcUhnRXbIqn3uB8S8wVLafMJY0Ty w2TLhhnMGRpJ2LMieRpBc37EXuMQnvCK4t+tN00p4nKjncE9utSCEuUQowg98C20hOwN TB0Q== X-Gm-Message-State: ACgBeo3+y53P+5j7nJ8ag0viDwTus9VSGWzKIpmPbhI4reu28W+OLUqc 4F966w/K6hSLVBEYvFXiAzbwYH8uCo/YRJJRxKrGECMGlv0= X-Google-Smtp-Source: AA6agR72u+aDDkC5+X1sixGp41Ut2pOiO5Y9GkNDaT9Nt3Tq/+4MPRt/BtxmSw0HU87nFmxLhO9N6n1cHzZT4gGnaIo= X-Received: by 2002:a1f:9d13:0:b0:376:7f81:9b85 with SMTP id g19-20020a1f9d13000000b003767f819b85mr2997628vke.18.1661763019982; Mon, 29 Aug 2022 01:50:19 -0700 (PDT) MIME-Version: 1.0 References: <8D53AD5B-7CFC-4820-9EE4-FEB365D327A8@woofle.net> In-Reply-To: Date: Mon, 29 Aug 2022 10:50:09 +0200 Message-ID: To: PHP Internals List Content-Type: text/plain; charset="UTF-8" Subject: Re: [PHP-DEV] RFC json_validate() - status: Under Discussion From: dev.juan.morales@gmail.com (juan carlos morales) There is still 1 open question on the RFC, and is about the return value. https://wiki.php.net/rfc/json_validate#open_issuesquestions I would appreciate your feedback on this. Even though I was told the RFC can go with 2 votings, I would like to know your thoughts about that open question, in short, the return value. The same thing was asked during code review of the pull request. I already expressed my opinion in the RFC, I prefer to return boolean and check errors using json_last_error() and I wrote down the details about this; instead of returning INT ... with 0 or JSON_ERROR_NONE representing successful validation. Thanks in advance. RFC: https://wiki.php.net/rfc/json_validate Implementation: https://github.com/php/php-src/pull/9399