Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118527
MIME-Version: 1.0
References: <CANMwmbN8_Km+urXbNO7oWvNteYA2mTPNYyRgfaoypEK1Cw4F0A@mail.gmail.com>
 <CA+p1FaZDm3-h_LoOwv619wFyPg+2pAM8qC2La438sU_SPHZnCg@mail.gmail.com>
 <CABdc3WqsDc+80ATdX9+qstOkf+eUYCAQNPeV_FXcHiFumVQb8A@mail.gmail.com>
 <8D53AD5B-7CFC-4820-9EE4-FEB365D327A8@woofle.net> <CABdc3Wo7_qJOtebvA2GNGFUGFAut3tJOShXDBLHnRKqhrwVJ-g@mail.gmail.com>
 <d2f2c96c-3d45-49fc-ad0b-16e5a578891c@www.fastmail.com> <CAGBsUrcVmKRz=X8B1pVxavh1WE3aYTOMEbiWeYqTgky67atAdw@mail.gmail.com>
 <CA+p1FaZF8C12xn7q7r+1SGVHKca-+KWrv0WB1X-fSawnDz07GQ@mail.gmail.com>
 <CANLbj-rfHh9T84WJxcXW3nSj44mmXdDHT_XDM26WWKbiJKvJxw@mail.gmail.com>
 <afe236de-e35f-487a-93a6-250efc0f3f9d@www.fastmail.com> <CANMwmbOZNBR0gog0V_UH7LDL9JPNpsEmhQKrEmBFhxu-nR6T_w@mail.gmail.com>
 <CANMwmbOs5EPg5wOv1ULy+DEGr3mrwN4R8COMmrwMdCtWF36nPw@mail.gmail.com> <CANMwmbNw8ovHyXVL5dQg9ea8X4KcHrpHxgw2Q9fCn_vjiTx5eA@mail.gmail.com>
In-Reply-To: <CANMwmbNw8ovHyXVL5dQg9ea8X4KcHrpHxgw2Q9fCn_vjiTx5eA@mail.gmail.com>
Date: Sat, 27 Aug 2022 01:50:10 +0100
Message-ID: <CA+p1FaY6N5E_g6LFNTbd7eZk4DoYVsg15ZcoYjLJi=DutinD-g@mail.gmail.com>
To: juan carlos morales <dev.juan.morales@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000053cd6405e72e6ab5"
Subject: Re: [PHP-DEV] RFC json_validate() - status: Under Discussion
From: davidgebler@gmail.com (David Gebler)

--00000000000053cd6405e72e6ab5
Content-Type: text/plain; charset="UTF-8"

Juan,
You can always offer two votes on the RFC - one for the function itself,
then one for should it return boolean or return an int representing the
json_last_error constants and let it be decided that way.

I think on the whole, I agree with the sentiment that returning boolean and
checking json_last_error() on false is probably the best / least worst
option.

So if I could vote, I would vote yes and for the boolean option, with a
secondary preference for returning int if boolean option is rejected.

And I was unconvinced about the whole idea originally, so a good example of
where positive, robust discussion can change someone's mind.

Good luck with progressing the RFC, I don't think I have anything else to
add.


On Sat, Aug 27, 2022 at 12:46 AM juan carlos morales <
dev.juan.morales@gmail.com> wrote:

> OMG, I need to take a rest, sorry for this, here it goes again; the
> about JSON_INVALID_UTF8_IGNORE opinion is the same, but previous code
> was wrong
>
> Code:
>
> <?php
>
> var_dump(json_decode("{ \"a\xb0b\" : \"dummy\" }", true, 512),
> json_last_error_msg());
> var_dump("------------");
> var_dump(json_decode("{ \"a\xb0b\" : \"dummy\" }", true, 512,
> JSON_INVALID_UTF8_IGNORE), json_last_error_msg());
>
> Result:
>
> NULL
> string(56) "Malformed UTF-8 characters, possibly incorrectly encoded"
> string(12) "------------"
> array(1) { ["ab"]=> string(5) "dummy" }
> string(8) "No error"
>
> Saying so, now ... yes I support and think is NEEDED the usage of the
> JSON_INVALID_UTF8_IGNORE , as json_validate() result goes in the same
> direction with json_decode(). I think we need to have this flag.
>
> RFC: https://wiki.php.net/rfc/json_validate
> Implementation: https://github.com/php/php-src/pull/9399
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>
>

--00000000000053cd6405e72e6ab5--