Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118525
MIME-Version: 1.0
References: <CANMwmbN8_Km+urXbNO7oWvNteYA2mTPNYyRgfaoypEK1Cw4F0A@mail.gmail.com>
 <CA+p1FaZDm3-h_LoOwv619wFyPg+2pAM8qC2La438sU_SPHZnCg@mail.gmail.com>
 <CABdc3WqsDc+80ATdX9+qstOkf+eUYCAQNPeV_FXcHiFumVQb8A@mail.gmail.com>
 <8D53AD5B-7CFC-4820-9EE4-FEB365D327A8@woofle.net> <CABdc3Wo7_qJOtebvA2GNGFUGFAut3tJOShXDBLHnRKqhrwVJ-g@mail.gmail.com>
 <d2f2c96c-3d45-49fc-ad0b-16e5a578891c@www.fastmail.com> <CAGBsUrcVmKRz=X8B1pVxavh1WE3aYTOMEbiWeYqTgky67atAdw@mail.gmail.com>
 <CA+p1FaZF8C12xn7q7r+1SGVHKca-+KWrv0WB1X-fSawnDz07GQ@mail.gmail.com>
 <CANLbj-rfHh9T84WJxcXW3nSj44mmXdDHT_XDM26WWKbiJKvJxw@mail.gmail.com>
 <afe236de-e35f-487a-93a6-250efc0f3f9d@www.fastmail.com> <CANMwmbOZNBR0gog0V_UH7LDL9JPNpsEmhQKrEmBFhxu-nR6T_w@mail.gmail.com>
In-Reply-To: <CANMwmbOZNBR0gog0V_UH7LDL9JPNpsEmhQKrEmBFhxu-nR6T_w@mail.gmail.com>
Date: Sat, 27 Aug 2022 01:41:05 +0200
Message-ID: <CANMwmbOs5EPg5wOv1ULy+DEGr3mrwN4R8COMmrwMdCtWF36nPw@mail.gmail.com>
To: PHP Internals List <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] RFC json_validate() - status: Under Discussion
From: dev.juan.morales@gmail.com (juan carlos morales)

El s=C3=A1b, 27 ago 2022 a las 1:31, juan carlos morales
(<dev.juan.morales@gmail.com>) escribi=C3=B3:
>
> =3D=3D=3D Open issues/concerns =3D=3D=3D
>
>
> @@@ Usage of JSON_INVALID_UTF8_IGNORE @@@
>
> - I have my doubts now, because of this codes:
>
> ```
> <php
>
> var_dump(json_validate("\"a\xb0b\""), json_last_error_msg());
> var_dump("------------");
> var_dump(json_validate("\"a\xb0b\"", 512, JSON_INVALID_UTF8_IGNORE),
> json_last_error_msg());
> ```
>
> Results:
>
> bool(false)
> string(56) "Malformed UTF-8 characters, possibly incorrectly encoded"
> string(12) "------------"
> bool(true)
> string(8) "No error"
>
>
> Gives different results, but ...
>
> ```
> <?php
>
> var_dump(json_decode("{ \"a\xb0b\" : \"dummy\" }"), json_last_error_msg()=
);
> var_dump("------------");
> var_dump(json_decode("{ \"a\xb0b\" : \"dummy\" }", 512,
> JSON_INVALID_UTF8_IGNORE), json_last_error_msg());
> ```
>
> Results in:
> NULL
> string(56) "Malformed UTF-8 characters, possibly incorrectly encoded"
> string(12) "------------"
> NULL
> string(56) "Malformed UTF-8 characters, possibly incorrectly encoded"
>
>
>
> So at a first look, seems the flag should also be remove, as with
> json_validate() we say its valid, but then on json_decode() we get
> NULL, even with the JSON_INVALID_UTF8_IGNORE provided; does not make
> sense I believe.
>
> What do you think? Is there a use case I am missing here? Is this flag
> worth to have still?
>

I made a huge mistake sorry, long day here, 1:30 am , the code for
json_decode should be as:

var_dump(json_decode("{ \"a\xb0b\" : \"dummy\" }"), true, 512,
json_last_error_msg());
var_dump("------------");
var_dump(json_decode("{ \"a\xb0b\" : \"dummy\" }", true, 512,
JSON_INVALID_UTF8_IGNORE), json_last_error_msg());

Resulting in

NULL
bool(true)
int(512)
string(56) "Malformed UTF-8 characters, possibly incorrectly encoded"
string(12)"------------"
array(1) { ["ab"]=3D> string(5) "dummy" }
string(8) "No error"


Saying so, now ... yes I support the usage of the
JSON_INVALID_UTF8_IGNORE , as json_validate() result goes in the same
direction with json_decode(). I think we need to have this flag.

RFC: https://wiki.php.net/rfc/json_validate
Implementation: https://github.com/php/php-src/pull/9399