Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118522
Date: Fri, 26 Aug 2022 23:17:40 +0100
To: internals@lists.php.net
User-Agent: K-9 Mail for Android
In-Reply-To: <86a071f4-41ee-33e0-92cd-2a76d5b480d8@bastelstu.be>
References: <302000df-5c3f-a86c-a608-2a45d2726ab1@bastelstu.be> <CAFPFaMLT0VL+AVnGeRMK2wO+-A_Mf3LCqMKnzqs1iK828GbM9w@mail.gmail.com> <86a071f4-41ee-33e0-92cd-2a76d5b480d8@bastelstu.be>
Message-ID: <F85B94BE-6BBF-41AE-9499-11EB1339487B@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: =?US-ASCII?Q?Re=3A_=5BPHP-DEV=5D_What_type_of_Exceptio?= =?US-ASCII?Q?n_to_use_for_unserialize=28=29_failure=3F?=
From: rowan.collins@gmail.com (Rowan Tommins)

On 25 August 2022 16:06:48 BST, "Tim D=C3=BCsterhus" wrote:

>- I've noticed that 'unserialize()' already emits E_WARNING for some type=
s of error (e=2Eg=2E out-of-bounds integers), so users already need to be p=
repared for E_WARNING to be emitted=2E I've adjusted the aforementioned Not=
ice to Warning, but we might be able to directly jump to UnserializationFai=
ledException from the existing warnings?


IMHO, any change from Warning or lower to Exception or Error is a clear Br=
eaking Change, because it can make a program that runs successfully under o=
ne version abort mid-process in another=2E

So, while it probably makes sense for all serialisation errors to consiste=
ntly throw, that should be planned for 9=2E0, and everything that's not alr=
eady an exception could raise a consistently formatted E_WARNING in 8=2E3=
=2E

Regards,

--=20
Rowan Tommins
[IMSoP]