Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:118516 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 15146 invoked from network); 26 Aug 2022 16:53:50 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 26 Aug 2022 16:53:50 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 2E83D1804AA for ; Fri, 26 Aug 2022 09:53:48 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,HTML_MESSAGE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15623 212.45.192.0/19 X-Spam-Virus: No X-Envelope-From: Received: from mail.gna.ch (mail.gna.ch [212.45.196.109]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Fri, 26 Aug 2022 09:53:47 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by darkcity.gna.ch (Postfix) with ESMTP id B0DF53A1D8F for ; Fri, 26 Aug 2022 18:53:45 +0200 (CEST) X-Virus-Scanned: amavisd-new at example.com Received: from mail.gna.ch ([127.0.0.1]) by localhost (darkcity.gna.ch [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id V9zfidIaTPI4 for ; Fri, 26 Aug 2022 18:53:45 +0200 (CEST) Received: from smtpclient.apple (unknown [IPv6:2a02:1210:2ea4:cf00:6172:ea08:1629:6505]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by darkcity.gna.ch (Postfix) with ESMTPSA id 395983A1D74 for ; Fri, 26 Aug 2022 18:53:45 +0200 (CEST) Content-Type: multipart/alternative; boundary="Apple-Mail=_A7716454-2919-4DFB-A209-CA38FE34ADC8" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Date: Fri, 26 Aug 2022 18:53:44 +0200 References: <355260c3-880f-a497-698f-c12175192485@gmx.de> To: PHP internals In-Reply-To: Message-ID: <088EFBD2-73B5-4C22-96DA-AEDEF7DFBD45@cschneid.com> X-Mailer: Apple Mail (2.3696.120.41.1.1) Subject: Re: [PHP-DEV] ksort breaking change From: cschneid@cschneid.com (Christian Schneider) --Apple-Mail=_A7716454-2919-4DFB-A209-CA38FE34ADC8 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Am 26.08.2022 um 18:28 schrieb Sara Golemon : > What I can see is two noble, but conflicting ideals: > 1/ sort() and ksort() should be consistent about their sorting = algorithms. > I think we can all agree about that in the ideal case, at least. > 2/ Behavior within a minor release should be self-consistent and > predictable. >=20 > Given the above, my initial inclination is to err on the side of > conservatism for 8.0.x at the least (we're nearly at the end of our = primary > bug-fix cycle anyway) by reverting the fix on our branch. > For 8.1, I think we have a more difficult decision to make with over a = year > of bug-fix releases to go, and I might be swayed to keep the fix = around > there. I agree with the description of the ideals but I'm not sure why you = think the resolution should be different of 8.0 than 8.1. We already transitioned our existing code base from 8.0 to 8.1, = including testing for changes due to the way numeric string are handled. = I think it is reasonable to adapt it for 8.2 (where another round of = breaking changes will have to be tested anyway) but I would not expect = to having to do this for a bug-fix release 8.1.x. That's why I'd rather have this change postponed to 8.2 (which is not = that far off anyway). Regards, - Chris --Apple-Mail=_A7716454-2919-4DFB-A209-CA38FE34ADC8--