Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:118513 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 4889 invoked from network); 26 Aug 2022 14:59:33 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 26 Aug 2022 14:59:33 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 282921804BA for ; Fri, 26 Aug 2022 07:59:33 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-vk1-f172.google.com (mail-vk1-f172.google.com [209.85.221.172]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Fri, 26 Aug 2022 07:59:32 -0700 (PDT) Received: by mail-vk1-f172.google.com with SMTP id d6so770438vko.7 for ; Fri, 26 Aug 2022 07:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=j6It8b8PoKq3gYNmwG8fcgpYegS1HSt+E1+nI/y7ieo=; b=IsqJCLLlRMkjCXHUBxBSDMGoLNv4JD/uwDgTFCZeVpdeLOOttQlsTfG075AWQk9gD8 UtJrDufHEfjMi2vGe/gw3i7eX8oSkzPlyeIZ9AAqTfRZpqpIgSwPBasMe3nOLI2vKDgO Sgwz2AxD08sQmiHyqFeG71o5VvKijpEAunutLnqdXE+jLbt6/Zjb+gJk/94djqDQHyKV /q9ELg9i8LDpzCELYOLtJz2wmUfzZwoBdNF+qaGSaIsW1D6i4l4WCmCq8Fufy2ciYZLp 7NWEsNHP71E6t1onC96qm5ILeB11HQbiDgNxYFmqW+wu1TjTP0efjE2Qu8pH9Lq88AVR H1Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=j6It8b8PoKq3gYNmwG8fcgpYegS1HSt+E1+nI/y7ieo=; b=tRY4j/lD/C53Ji0xnobfMYmM4hl1T2AtRtdqzrNYXZefTZXKbX7DUDWBW8K1yclH4v w9weWUTPoYTsbHseulBK8E1usMM/+WggwPKtCGDw7wSpcu/khLWhwTC+NkMN6PV+rUJF grnsoldo6JaAvnHwZojl6buOiBF5sBOpI0rB754S7sJ8BUlvuhst9F5Yfqr4RQ37Z+6r 33WOtNSSYKT21/qA6kbrgDnYYDzYhfry+T26bynGjHLX7Pw4fKYHUW/zn8PvVesLVYHm uuUVHf0us2Ol4f0xswSbOuRjfe3Yk53EbGOBzqGmvzn4oH/O4gdir56LcnU3QTYEn65/ f/NQ== X-Gm-Message-State: ACgBeo2Jt5c8Olq2oVsSsri//jEbkdwdg0lo8GtrYVZMtnamOdQkhh9r A0VHtBaXMisDPTZYyUnOh0F3DboO0FL1FH3le/C+iN0o X-Google-Smtp-Source: AA6agR4FVfYeIg62Xcu3IR9QentIOUzDa4KTJ2dgsyEjtkBbA6VrH5pZBUoSbKl799q79PY7BAX6h20MvmRjz2SE11U= X-Received: by 2002:a1f:a74c:0:b0:379:1113:4f07 with SMTP id q73-20020a1fa74c000000b0037911134f07mr3336634vke.40.1661525971988; Fri, 26 Aug 2022 07:59:31 -0700 (PDT) MIME-Version: 1.0 References: <355260c3-880f-a497-698f-c12175192485@gmx.de> <9296DFB3-6D1A-4395-9876-3BB81B7F509A@cschneid.com> <990c1226-867a-880a-0a27-3991676f4fd7@bastelstu.be> In-Reply-To: <990c1226-867a-880a-0a27-3991676f4fd7@bastelstu.be> Date: Fri, 26 Aug 2022 16:59:20 +0200 Message-ID: To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= Cc: Christian Schneider , PHP Developers Mailing List Content-Type: multipart/alternative; boundary="00000000000058752205e7262917" Subject: Re: [PHP-DEV] ksort breaking change From: dev.juan.morales@gmail.com (juan carlos morales) --00000000000058752205e7262917 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Oh! My bad. Nice work! Cheers El vie., 26 de agosto de 2022 16:51, Tim D=C3=BCsterhus escribi=C3=B3: > Hi > > On 8/26/22 16:15, juan carlos morales wrote: > > Seems like we Don't Have tests for the function or we should enhance th= e > > existing ones. If We would Have proper tests the FIX would break it (as= I > > Don't see tests in the fix itself).....That is why I say so. > > > > Various tests were adjusted in: > https://github.com/php/php-src/pull/9293/files > > Best regards > Tim D=C3=BCsterhus > --00000000000058752205e7262917--