Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:118512 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 3250 invoked from network); 26 Aug 2022 14:51:36 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 26 Aug 2022 14:51:36 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 51E1C1804B5 for ; Fri, 26 Aug 2022 07:51:34 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS24940 176.9.0.0/16 X-Spam-Virus: No X-Envelope-From: Received: from chrono.xqk7.com (chrono.xqk7.com [176.9.45.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Fri, 26 Aug 2022 07:51:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bastelstu.be; s=mail20171119; t=1661525491; bh=K2D8Qb7Tviz21YZNZo1gc3yNvbk5yBn9AaBT6IZIHQw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=I4MSo30ZTHXvS7tRuwiXyK/avQD2B3yaV4T0S2IMmdRWBLr4Y4I2dZrluzHFI2EHN YeCLe221RlzBZ0OUC1bxbAZ8EQmEPCk06wHWjwPZo99YDrqQCgRud6Y7JP2qKIOZCV 7LTmBuJm2AzazLYSuAff4wJ73p+vWha6FzITH2do1ESkxSD1FFpTjarugo+uQW0HtI 51DWmKnED5tg573u/pb+2pmmZXLa6sVla2pFY74Lj7+qPyehlHQ0MBnbC0p+rSUBey HNClzSyeffKqQwrTa/wgAHEro/T9BI2GW1nxDew0n1L3SkPHIAt0snZxiXTEDv8/bN UhqrItQVTziAA== Message-ID: <990c1226-867a-880a-0a27-3991676f4fd7@bastelstu.be> Date: Fri, 26 Aug 2022 16:51:31 +0200 MIME-Version: 1.0 Content-Language: en-US To: juan carlos morales , Christian Schneider Cc: PHP Developers Mailing List References: <355260c3-880f-a497-698f-c12175192485@gmx.de> <9296DFB3-6D1A-4395-9876-3BB81B7F509A@cschneid.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [PHP-DEV] ksort breaking change From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=) Hi On 8/26/22 16:15, juan carlos morales wrote: > Seems like we Don't Have tests for the function or we should enhance the > existing ones. If We would Have proper tests the FIX would break it (as I > Don't see tests in the fix itself).....That is why I say so. > Various tests were adjusted in: https://github.com/php/php-src/pull/9293/files Best regards Tim Düsterhus