Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118510
MIME-Version: 1.0
References: <CAMs36Hdg7Ydx+B6b1fSGosds3mC2KppN7xbfOi3zwPW8cRncsQ@mail.gmail.com>
 <355260c3-880f-a497-698f-c12175192485@gmx.de> <9296DFB3-6D1A-4395-9876-3BB81B7F509A@cschneid.com>
In-Reply-To: <9296DFB3-6D1A-4395-9876-3BB81B7F509A@cschneid.com>
Date: Fri, 26 Aug 2022 16:15:00 +0200
Message-ID: <CANMwmbPjWjZyhkdmt5=6WwiuF3ixK66c8s8v_iGN-gre1Ox79A@mail.gmail.com>
To: Christian Schneider <cschneid@cschneid.com>
Cc: PHP Developers Mailing List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000ccbe2705e7258a52"
Subject: Re: [PHP-DEV] ksort breaking change
From: dev.juan.morales@gmail.com (juan carlos morales)

--000000000000ccbe2705e7258a52
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Seems like we Don't Have tests for the function or we should enhance the
existing ones. If We would Have proper tests the FIX would break it (as I
Don't see tests in the fix itself).....That is why I say so.

I Am not in my computer atm. I Will check this later

El vie., 26 de agosto de 2022 15:01, Christian Schneider <
cschneid@cschneid.com> escribi=C3=B3:

> Am 26.08.2022 um 14:19 schrieb Christoph M. Becker <cmbecker69@gmx.de>:
> > On 26.08.2022 at 05:15, Go Kudo wrote:
> >
> >> In the actively supported version of PHP, `ksort()` has been modified =
to
> >> include BC Break.
> >>
> >> https://github.com/php/php-src/issues/9296
> >>
> >> This may seem like an appropriate bug fix, but it is a clear BC Break.=
 I
> >> think this change should only be introduced in PHP 8.2 and later.
> >
> > In this case, the functions didn't behave as documented, namely to
> > conform to the general conversion rules, which had a relevant change in
> > PHP 8.0.  Apparently, this case has been overlooked when the change had
> > been implemented, and only been noticed recently (what still surprises
> > me).  Anyway, fixing the issue now is not really introducing a BC break=
,
> > since code relying on the previous behavior did not conform to the
> > documentation.
>
>
> I don't really agree with your definition of BC break.
>
> The behavior of the function with a mix of numeric/non-numeric string key=
s
> changes from 8.1.9 to 8.1.10 which in my world qualifies as a BC break.
>
> Regards,
> - Chris
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>
>

--000000000000ccbe2705e7258a52--