Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:118509 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 92721 invoked from network); 26 Aug 2022 13:01:11 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 26 Aug 2022 13:01:11 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id C5C861804A9 for ; Fri, 26 Aug 2022 06:01:10 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15623 212.45.192.0/19 X-Spam-Virus: No X-Envelope-From: Received: from mail.gna.ch (mail.gna.ch [212.45.196.109]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Fri, 26 Aug 2022 06:01:10 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by darkcity.gna.ch (Postfix) with ESMTP id 7C3633A13DC for ; Fri, 26 Aug 2022 15:01:08 +0200 (CEST) X-Virus-Scanned: amavisd-new at example.com Received: from mail.gna.ch ([127.0.0.1]) by localhost (darkcity.gna.ch [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P5U7TiwkWNui for ; Fri, 26 Aug 2022 15:01:07 +0200 (CEST) Received: from smtpclient.apple (unknown [IPv6:2a02:1210:2ea4:cf00:6172:ea08:1629:6505]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by darkcity.gna.ch (Postfix) with ESMTPSA id C6A3E3A0DA2 for ; Fri, 26 Aug 2022 15:01:07 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Date: Fri, 26 Aug 2022 15:01:07 +0200 References: <355260c3-880f-a497-698f-c12175192485@gmx.de> To: PHP Developers Mailing List In-Reply-To: <355260c3-880f-a497-698f-c12175192485@gmx.de> Message-ID: <9296DFB3-6D1A-4395-9876-3BB81B7F509A@cschneid.com> X-Mailer: Apple Mail (2.3696.120.41.1.1) Subject: Re: [PHP-DEV] ksort breaking change From: cschneid@cschneid.com (Christian Schneider) Am 26.08.2022 um 14:19 schrieb Christoph M. Becker : > On 26.08.2022 at 05:15, Go Kudo wrote: >=20 >> In the actively supported version of PHP, `ksort()` has been modified = to >> include BC Break. >>=20 >> https://github.com/php/php-src/issues/9296 >>=20 >> This may seem like an appropriate bug fix, but it is a clear BC = Break. I >> think this change should only be introduced in PHP 8.2 and later. >=20 > In this case, the functions didn't behave as documented, namely to > conform to the general conversion rules, which had a relevant change = in > PHP 8.0. Apparently, this case has been overlooked when the change = had > been implemented, and only been noticed recently (what still surprises > me). Anyway, fixing the issue now is not really introducing a BC = break, > since code relying on the previous behavior did not conform to the > documentation. I don't really agree with your definition of BC break. The behavior of the function with a mix of numeric/non-numeric string = keys changes from 8.1.9 to 8.1.10 which in my world qualifies as a BC = break. Regards, - Chris