Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118507
Message-ID: <355260c3-880f-a497-698f-c12175192485@gmx.de>
Date: Fri, 26 Aug 2022 14:19:40 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.13.0
Content-Language: de-DE
To: Go Kudo <g-kudo@colopl.co.jp>, internals@lists.php.net,
 sara Golemon <pollita@php.net>, Gabriel Caruso <carusogabriel34@gmail.com>
References: <CAMs36Hdg7Ydx+B6b1fSGosds3mC2KppN7xbfOi3zwPW8cRncsQ@mail.gmail.com>
In-Reply-To: <CAMs36Hdg7Ydx+B6b1fSGosds3mC2KppN7xbfOi3zwPW8cRncsQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: ksort breaking change
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 26.08.2022 at 05:15, Go Kudo wrote:

> In the actively supported version of PHP, `ksort()` has been modified to
> include BC Break.
>
> https://github.com/php/php-src/issues/9296
>
> This may seem like an appropriate bug fix, but it is a clear BC Break. I
> think this change should only be introduced in PHP 8.2 and later.

In this case, the functions didn't behave as documented, namely to
conform to the general conversion rules, which had a relevant change in
PHP 8.0.  Apparently, this case has been overlooked when the change had
been implemented, and only been noticed recently (what still surprises
me).  Anyway, fixing the issue now is not really introducing a BC break,
since code relying on the previous behavior did not conform to the
documentation.

> Fortunately, there is not yet a release in each version that incorporate=
s
> this change. I think it is possible to revert now.

Well, the fix is part of the currents RCs; that doesn't make it
impossible to revert, but RMs should have a say in that.  Thus I'm
adding Sara and Gabriel as recepients.

=2D-
Christoph M. Becker