Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118501
Message-ID: <6c8090ad-1a20-e636-f688-7f8b2863b026@bastelstu.be>
Date: Fri, 26 Aug 2022 12:02:24 +0200
MIME-Version: 1.0
Content-Language: en-US
To: Paul Crovella <paul.crovella@gmail.com>, internals@lists.php.net
References: <CANMwmbN8_Km+urXbNO7oWvNteYA2mTPNYyRgfaoypEK1Cw4F0A@mail.gmail.com>
 <CAJvSBVPF12zMwm6vavLz_Zv06_m+DVdkkVLbKeG_NPKnN07cgw@mail.gmail.com>
In-Reply-To: <CAJvSBVPF12zMwm6vavLz_Zv06_m+DVdkkVLbKeG_NPKnN07cgw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] RFC json_validate() - status: Under Discussion
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 8/26/22 10:56, Paul Crovella wrote:
> I'm for this as well. Though something more than a boolean is useful to
> indicate when the max depth has been exceeded as that's not strictly a
> problem with the json's validity.
> 

Yes, it's not strictly invalid JSON, but I expect json_validate() to be 
used as a check to mean "will json_decode() be able to decode the JSON 
with these parameters". Then `false` is the logical result when 
exceeding the depth.

Also json_last_error() will do what you expect it to do: 
https://github.com/php/php-src/pull/9399/files#diff-1cdb6c7eb68aa60b323b056a06d6f7427b38e9d8d967ce97992129ff65c7951eR55. 
So you can find out the reason why the JSON is invalid.

Best regards
Tim Düsterhus