Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:118500 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 60481 invoked from network); 26 Aug 2022 10:00:13 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 26 Aug 2022 10:00:13 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 2244E18054B for ; Fri, 26 Aug 2022 03:00:13 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Fri, 26 Aug 2022 03:00:12 -0700 (PDT) Received: by mail-vs1-f43.google.com with SMTP id 67so1172685vsv.2 for ; Fri, 26 Aug 2022 03:00:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc; bh=XY7waAsKO3oCTsXOlYPYzmwGqSiYqt7RWsTuEQPPgXU=; b=H3hZuQAjUw1hwEY1OsRWJdhGXYXDT+APdQoxrbQpbmmUhRgChxn5QSG8ZCDDvl8T/I Zkb5nlxQc/J1KUUTq2gb/1FpF8jK/JXE3fTiqHI/r0V7BRIE8dw7Pln3oVyIn6jrEv6I 1IZKq7NiOAjlnXyXvFkmUiBcGuiVIU7RqDnDALGL6ApSfwNBcsUBTCLGZlhvUXdDhfjh 0LoT65Jiuip6Y0WTbIpQEIt8UwP1slQLR1uaNXNMtfzDlFl/n1GSQlsSDbAwP/9eDxfw pN1Y+1RSGNu39IVJUZvma1y9MH9biK0fAK/EoqR60QSqWFMkKEW48Zre0xQaLwFs+esL 4LJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc; bh=XY7waAsKO3oCTsXOlYPYzmwGqSiYqt7RWsTuEQPPgXU=; b=THDB5NGfBL+TDKVNAOCIx6ezybnI/kNemercelseIDON+OE1HepCOJlHgoysUdktcy RO5Ws1cuYlnfT3XY3/CO9bSsNePXPFZTKqh7MMsjm0kGtLjvqy0NUwIV+UQCb0yiy3Rf oJQMCpJbKYeAwf/B33HbPM0IvsfD6fz+n8ziX0zryAWj6P9t8cowJBiI8h3zblCSXkTv 03b50GtRz4BKulOR8HzDBftzKIwzfjRlNxjFdefj45DDUBxm2b2akcOuzkTWsLxOgFLV F5JTuRgADPfYbAuQpRDM0mbW2R2p3kGHJj7GChc60VFb+sXJqdgwSvk08V3vPjFU0uHU ow4g== X-Gm-Message-State: ACgBeo33dwDA0CUwrkj6usp4F+yazXyV8qLVjXFBccOaHhrT+pzY1tOY Klv4IWsYbWB/5heBi+P98EoygWHTpczAXZRmusaDh/Yfj5s= X-Google-Smtp-Source: AA6agR5abvssBwtivVs7FrarJC7rRYQCSypsibG/9AQ1AKC0M68GJvs1HjesFBiFEFfSQeJpjDFjjULTKBUDXx9cKBY= X-Received: by 2002:a67:cb9d:0:b0:390:350f:2304 with SMTP id h29-20020a67cb9d000000b00390350f2304mr2710077vsl.83.1661508012184; Fri, 26 Aug 2022 03:00:12 -0700 (PDT) MIME-Version: 1.0 References: <63088acb.170a0220.9348c.3fd3SMTPIN_ADDED_MISSING@mx.google.com> In-Reply-To: Date: Fri, 26 Aug 2022 12:00:01 +0200 Message-ID: To: Peter Bowyer Cc: Paul Crovella , PHP Internals List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] RFC json_validate() - status: Under Discussion From: dev.juan.morales@gmail.com (juan carlos morales) El vie, 26 ago 2022 a las 11:55, Peter Bowyer () escribi=C3=B3: > > That's a good point which I had overlooked. Does an exception make most > sense when this happens? > > Peter I just got a code review from Derick Rethans explaining me that a validation routine should not throw an exception. I think is a good idea to take it out, after all , the depth parameter is part of the validation too. RFC: https://wiki.php.net/rfc/json_validate Implementation: https://github.com/php/php-src/pull/9399