Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118491
MIME-Version: 1.0
References: <CANMwmbN8_Km+urXbNO7oWvNteYA2mTPNYyRgfaoypEK1Cw4F0A@mail.gmail.com>
 <CAJvSBVPF12zMwm6vavLz_Zv06_m+DVdkkVLbKeG_NPKnN07cgw@mail.gmail.com>
In-Reply-To: <CAJvSBVPF12zMwm6vavLz_Zv06_m+DVdkkVLbKeG_NPKnN07cgw@mail.gmail.com>
Date: Fri, 26 Aug 2022 11:19:52 +0200
Message-ID: <CANMwmbObW+r6j1M8qFJFkDJ_dXUaFFX1gA6mbEBBSsdKM3pS=w@mail.gmail.com>
To: Peter Bowyer <phpmailinglists@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] RFC json_validate() - status: Under Discussion
From: dev.juan.morales@gmail.com (juan carlos morales)

El vie, 26 ago 2022 a las 10:28, Peter Bowyer
(<phpmailinglists@gmail.com>) escribi=C3=B3:
>
> Hi Juan,
>
> On Thu, 25 Aug 2022 at 17:02, juan carlos morales <dev.juan.morales@gmail=
.com> wrote:
>>
>> RFC: https://wiki.php.net/rfc/json_validate
>
>
> Thanks for bringing forward this RFC. I am in favour of this change, as y=
ou can't efficiently validate JSON in userland.
>
> Like Rowan I'm not convinced JSON_THROW_ON_ERROR belongs here. I can't th=
ink of a case where more than a boolean response is needed.
>
> Peter

Seems that will be a good idea to take out the usage of the flag
JSON_THROW_ON_ERROR after all. That was a nice and objective critic
and I appreciate it. Thanks! I will take it out of the implementation.

Regards

RFC: https://wiki.php.net/rfc/json_validate

Implementation: https://github.com/php/php-src/pull/9399