Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118490
MIME-Version: 1.0
References: <CANMwmbN8_Km+urXbNO7oWvNteYA2mTPNYyRgfaoypEK1Cw4F0A@mail.gmail.com>
 <CA+p1FaZDm3-h_LoOwv619wFyPg+2pAM8qC2La438sU_SPHZnCg@mail.gmail.com>
 <CABdc3WqsDc+80ATdX9+qstOkf+eUYCAQNPeV_FXcHiFumVQb8A@mail.gmail.com>
 <8D53AD5B-7CFC-4820-9EE4-FEB365D327A8@woofle.net> <CABdc3Wo7_qJOtebvA2GNGFUGFAut3tJOShXDBLHnRKqhrwVJ-g@mail.gmail.com>
In-Reply-To: <CABdc3Wo7_qJOtebvA2GNGFUGFAut3tJOShXDBLHnRKqhrwVJ-g@mail.gmail.com>
Date: Fri, 26 Aug 2022 11:14:42 +0200
Message-ID: <CAJmy8YF2wgF-X3OY1vXbqNLX9wiDTdn8ro3FH2ReOwcOkASk=Q@mail.gmail.com>
To: =?UTF-8?Q?Micha=C5=82_Marcin_Brzuchalski?= <michal.brzuchalski@gmail.com>
Cc: Dusk <dusk@woofle.net>, David Gebler <davidgebler@gmail.com>, 
	juan carlos morales <dev.juan.morales@gmail.com>, PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000059061705e7215a49"
Subject: Re: [PHP-DEV] RFC json_validate() - status: Under Discussion
From: divinity76@gmail.com (Hans Henrik Bergan)

--00000000000059061705e7215a49
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

quote
> you can't efficiently validate JSON in userland

Has anyone actually put that claim to the test? Has anyone actually made a
userland json validator (not just wrap json_decode()/json_last_error()) for
performance comparison?
( if not, https://www.json.org/JSON_checker/JSON_checker.c  would probably
be a good start)

On Fri, 26 Aug 2022 at 11:00, Micha=C5=82 Marcin Brzuchalski <
michal.brzuchalski@gmail.com> wrote:

> Hi Dusk,
>
> pt., 26 sie 2022 o 08:17 Dusk <dusk@woofle.net> napisa=C5=82(a):
>
> > On Aug 25, 2022, at 21:47, Micha=C5=82 Marcin Brzuchalski <
> > michal.brzuchalski@gmail.com> wrote:
> > > The same goes here and I'm not convinced we should introduce next sma=
ll
> > function that can be simply implemented in user land.
> >
> > What "simple implementation in userland" do you have in mind? Can you
> > provide an example?
> >
> > json_decode() is not an acceptable substitute here -- as David Gebler h=
as
> > observed, decoding a large JSON structure can have a significant impact
> on
> > memory usage, even if the data is immediately discarded. Any
> implementation
> > based on string processing, on the other hand, is likely to be
> dramatically
> > slower, and may have subtle differences in behavior from PHP's JSON
> parser.
>
>
> A `json_decode()` is a substitute that IMO solves 99% of use cases.
> If I'd follow your logic and accept every small addition that handles 1% =
of
> use cases, somebody will raise another RFC
> for simplexml_validate_string or yaml_validate and the next
> PhpToken::validate.
> All above can be valid if we trust that people normally validate 300MB
> payloads to do nothing if they DON'T fail and there is nothing strange
> about that.
>
> Cheers,
>

--00000000000059061705e7215a49--