Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118486
MIME-Version: 1.0
References: <CANMwmbN8_Km+urXbNO7oWvNteYA2mTPNYyRgfaoypEK1Cw4F0A@mail.gmail.com>
 <CA+p1FaZDm3-h_LoOwv619wFyPg+2pAM8qC2La438sU_SPHZnCg@mail.gmail.com> <CABdc3WqsDc+80ATdX9+qstOkf+eUYCAQNPeV_FXcHiFumVQb8A@mail.gmail.com>
In-Reply-To: <CABdc3WqsDc+80ATdX9+qstOkf+eUYCAQNPeV_FXcHiFumVQb8A@mail.gmail.com>
Date: Fri, 26 Aug 2022 08:52:50 +0200
Message-ID: <CANMwmbMWXF49pm5sU-dk-5gJFgxyd8o7j0ERMaSsxNbWsUk+RQ@mail.gmail.com>
To: =?UTF-8?Q?Micha=C5=82_Marcin_Brzuchalski?= <michal.brzuchalski@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] RFC json_validate() - status: Under Discussion
From: dev.juan.morales@gmail.com (juan carlos morales)

El vie, 26 ago 2022 a las 6:47, Micha=C5=82 Marcin Brzuchalski
(<michal.brzuchalski@gmail.com>) escribi=C3=B3:
>
>
> I share the same opinion you expressed here even though you admit in rece=
nt email that you changed your mind.
>
> In recent versions we tend to accept more and more small standard library=
 functions with IMO questionable argumentation. The same goes here and I'm =
not convinced we should introduce next small function that can be simply im=
plemented in user land.

Sorry but I dont think that a JSON parser with memory usage zero (or
maybe a few bytes) can be simply done in the userland. This function
(json_validate) is small by itself, but gives you access to the JSON
parser. Can you please provide an example of what you commented?

> Any example testing > 3MB JSON string are for me edge cases that normally=
 don't happen often to deserve special treatment.

I don't agree with your definition of "edge case" here, as edge cases
depend/belong on/to the system under analysis.

By the way, the test case provided in the PR , "test 005" uses a
json-string of about 3 MB (maybe 3.1) , and in order to decode it
json_decode() needs something around 109 MB of memory. For me,
validation can be done in a better and efficient way, like it has been
probe with this proposal.

> If we keep the tendency to pollute already bloated standard library with =
an army of small functions that could have not exists and be replaced with =
normal PHP counterparts IMHO we'll end with frustration from developers as =
I believe DX slowly falls down here.

Last but not least, I want to say that the function json_validate() is
small, easy to maintain and extend if needed, and at the same gives us
access to something that is not trivial to write in userland .... the
existing JSON parser.


RFC: https://wiki.php.net/rfc/json_validate

Implementation: https://github.com/php/php-src/pull/9399