Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118482
MIME-Version: 1.0
References: <CANMwmbN8_Km+urXbNO7oWvNteYA2mTPNYyRgfaoypEK1Cw4F0A@mail.gmail.com>
 <30876360-1d4f-8097-0b58-fd902f1fa009@gmail.com> <CANMwmbMuJUYtJsRGtKJBBoaHXotoTcAdcovp5pzQTrAzi-bZBg@mail.gmail.com>
 <816aeb23-523a-f81a-7eba-d12a4d7292d3@gmail.com> <CANMwmbO=eLotPja-gyO5SnzDEh_t21SPKNQt_Q4u=2H59j7gOA@mail.gmail.com>
 <CANMwmbN7wy4mZaOOGCzti3xzBmuQNP=rd4AN6T54yW4rP19i1Q@mail.gmail.com> <CA+p1Faa4ERAQ89npuFEgHqo88yc_35zRXBZrj3JqNT11SJxP6g@mail.gmail.com>
In-Reply-To: <CA+p1Faa4ERAQ89npuFEgHqo88yc_35zRXBZrj3JqNT11SJxP6g@mail.gmail.com>
Date: Fri, 26 Aug 2022 01:55:05 +0200
Message-ID: <CANMwmbMawTQjw6K9UqnZRYaiDKMcjp7VegnJYKMSAjd_CXWvrA@mail.gmail.com>
To: David Gebler <davidgebler@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] RFC json_validate() - status: Under Discussion
From: dev.juan.morales@gmail.com (juan carlos morales)

> Having actually compiled the branch and tried it out, I have to say regar=
dless of whether validating arbitrarily large blocks of JSON without being =
interested in the contents is a common or more niche use case, the memory s=
avings ARE highly impressive. I had thought that because the function was b=
uilt on top of the existing parser and is still parsing the entire string (=
or up until invalid JSON is encountered), the performance saving for a very=
 large input would be smaller than it is.
>
> I tested using a 75MB valid JSON input - a string large enough that it's =
not going to be very common. The processing time isn't hugely different, th=
e saving appears to be around maybe 20-25% (and it's not a significant amou=
nt of time using either json_decode or json_validate, even on an input of t=
his size, about half a second on my machine for both). But the memory savin=
g is enormous, almost total. Gone from needing ~5x the size of the input to=
 almost literally just a few extra bytes.
>
> I'm persuaded now on both that benchmarking and having had a closer look =
at the implementation PR, which is clearly a minimal and easily maintainabl=
e change.
>
> As I've said, my feelings are irrelevant to the extent I'm not a voter, b=
ut I am in principle a +1 thumbs up for including this now.
>
>

David, thanks very much for sharing your results and opinion.

RFC: https://wiki.php.net/rfc/json_validate

Implementation: https://github.com/php/php-src/pull/9399