Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118480
MIME-Version: 1.0
References: <CANMwmbN8_Km+urXbNO7oWvNteYA2mTPNYyRgfaoypEK1Cw4F0A@mail.gmail.com>
 <30876360-1d4f-8097-0b58-fd902f1fa009@gmail.com> <CANMwmbMuJUYtJsRGtKJBBoaHXotoTcAdcovp5pzQTrAzi-bZBg@mail.gmail.com>
 <816aeb23-523a-f81a-7eba-d12a4d7292d3@gmail.com> <CANMwmbO=eLotPja-gyO5SnzDEh_t21SPKNQt_Q4u=2H59j7gOA@mail.gmail.com>
 <CANMwmbN7wy4mZaOOGCzti3xzBmuQNP=rd4AN6T54yW4rP19i1Q@mail.gmail.com>
In-Reply-To: <CANMwmbN7wy4mZaOOGCzti3xzBmuQNP=rd4AN6T54yW4rP19i1Q@mail.gmail.com>
Date: Thu, 25 Aug 2022 23:44:10 +0100
Message-ID: <CA+p1Faa4ERAQ89npuFEgHqo88yc_35zRXBZrj3JqNT11SJxP6g@mail.gmail.com>
To: juan carlos morales <dev.juan.morales@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000dc060e05e7188908"
Subject: Re: [PHP-DEV] RFC json_validate() - status: Under Discussion
From: davidgebler@gmail.com (David Gebler)

--000000000000dc060e05e7188908
Content-Type: text/plain; charset="UTF-8"

Having actually compiled the branch and tried it out, I have to say
regardless of whether validating arbitrarily large blocks of JSON without
being interested in the contents is a common or more niche use case, the
memory savings ARE highly impressive. I had thought that because the
function was built on top of the existing parser and is still parsing the
entire string (or up until invalid JSON is encountered), the performance
saving for a very large input would be smaller than it is.

I tested using a 75MB valid JSON input - a string large enough that it's
not going to be very common. The processing time isn't hugely different,
the saving appears to be around maybe 20-25% (and it's not a significant
amount of time using either json_decode or json_validate, even on an input
of this size, about half a second on my machine for both). But the memory
saving is enormous, almost total. Gone from needing ~5x the size of the
input to almost literally just a few extra bytes.

I'm persuaded now on both that benchmarking and having had a closer look at
the implementation PR, which is clearly a minimal and easily maintainable
change.

As I've said, my feelings are irrelevant to the extent I'm not a voter, but
I am in principle a +1 thumbs up for including this now.

--000000000000dc060e05e7188908--