Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118477
Message-ID: <816aeb23-523a-f81a-7eba-d12a4d7292d3@gmail.com>
Date: Thu, 25 Aug 2022 22:15:42 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Content-Language: en-GB
To: PHP Internals <internals@lists.php.net>
References: <CANMwmbN8_Km+urXbNO7oWvNteYA2mTPNYyRgfaoypEK1Cw4F0A@mail.gmail.com>
 <30876360-1d4f-8097-0b58-fd902f1fa009@gmail.com>
 <CANMwmbMuJUYtJsRGtKJBBoaHXotoTcAdcovp5pzQTrAzi-bZBg@mail.gmail.com>
In-Reply-To: <CANMwmbMuJUYtJsRGtKJBBoaHXotoTcAdcovp5pzQTrAzi-bZBg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] RFC json_validate() - status: Under Discussion
From: rowan.collins@gmail.com (Rowan Tommins)

[Replying to list - make sure to hit "Reply List" or "Reply All", not 
"Reply" in your mail client]

On 25/08/2022 21:59, juan carlos morales wrote:
> Hello Rowan thanks for participating.
>
> My answer for your comments would be:
>
> === Regarding JSON_THROW_ON_ERROR ===
> I think is a valid point from your side, and I am open to change the 
> implementation if the maintainers believe so. I leave it there as it 
> existed in json_decode() and wanted to give the developer the option 
> to use it or not. But as I said, you hae a valid point, that I also like.


Just to clarify, "the maintainers" of PHP are basically everyone on this 
list, trying to reach a consensus; there isn't really any core group 
that makes the final decision. There is a binding vote at the end of the 
RFC process, but it's in principle just a way to measure that consensus.


>
> === Regarding the examples you mentioned ===
> The one from humhub and Symfony http-kernel, yes you are right, I will 
> take them out from the RFC right now. Nice catch.
>
> But the Magento one, I took a look again, and I still believe is right 
> example, because the only reason is using json_decode() for, is to 
> validate only. Am I missing something here?


It's not entirely clear *what* that Magento code is doing, but it's 
definitely not just validation: the output of json_decode is passed to 
$this->_jsonEncoder->encode(); if it was just validating, it would 
return $input, or true. My guess is that like the Symfony example it is 
"pretty-printing" existing JSON strings.


Regards,

-- 
Rowan Tommins
[IMSoP]