Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118441
MIME-Version: 1.0
References: <CAEKnhAEJ+bOnvES_5vmrOgP-PdXuw=M6AezY0Yh2Xi-nkx5RAA@mail.gmail.com>
 <EE4B4FF7-19AD-4A75-A0BC-CFE7B002A482@php.net>
In-Reply-To: <EE4B4FF7-19AD-4A75-A0BC-CFE7B002A482@php.net>
Date: Thu, 18 Aug 2022 16:04:09 +0100
Message-ID: <CAEKnhAE1Wsg=u9Eo2VoNKi=J7XpMnCwpK0y24vbSMqQC95UVBw@mail.gmail.com>
To: Ben Ramsey <ramsey@php.net>
Cc: PHP internals list <internals@lists.php.net>, sergey@php.net, 
	Pierrick Charron <pierrick@php.net>
Content-Type: multipart/alternative; boundary="000000000000cb67e305e6854bfe"
Subject: Re: Additional small features for 8.2
From: bukka@php.net (Jakub Zelenka)

--000000000000cb67e305e6854bfe
Content-Type: text/plain; charset="UTF-8"

On Thu, Aug 18, 2022 at 3:37 PM Ben Ramsey <ramsey@php.net> wrote:

> > On Aug 18, 2022, at 08:46, Jakub Zelenka <bukka@php.net> wrote:
> >
> > Hi,
> >
> > There are some small self contained features that would be good to get
> to 8.2 unless there are any objections ofc.
> >
> > Make libxml_set_external_entity_loader() return the previous loader
> > https://github.com/php/php-src/pull/7977
> >
> > Improved responses to different requests on static resources in built-in
> web server
> > https://github.com/php/php-src/pull/8215
> >
> > Implement FR #76935: OpenSSL chacha20-poly1305 AEAD support
> > https://github.com/php/php-src/pull/9366
> >
> > Add openssl_cipher_key_length function
> > https://github.com/php/php-src/pull/9368
> >
> >
> > As it needs to be done before the first RC, I will wait for a week and
> if there are no objection, I will merge them.
> >
> > Thanks
> >
> > Jakub
>
>
> Feature freeze is at the first beta release, not the first RC.
>
>
Those are small self contained features so they should be pretty safe to
add. It's pretty much the same as just proposed FILTER_FLAG_NO_SCIENTIFIC
[1]. We actually used to merge those to the patch releases so I could
technically target 8.1 or even 8.0 as this was historically allowed but
thought that it might be better to just target beta. Maybe the only
exception from those is OpenSSL chacha20-poly1305 AEAD which is sort of a
bug fix but still think this one is better just for 8.2 as it might be
quite confusing to identify since when it is supported in 8.1. Also when
Nikita introduced OCB mode in the patch release it broke LibreSSL so I want
to be a bit more careful (even though this is done quite safely in terms of
compilation checks).

[1] https://news-web.php.net/php.internals/118436

Regards

Jakub

--000000000000cb67e305e6854bfe--