Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118415
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\))
In-Reply-To: <b814dad0-a15b-a40c-4c39-3300a7f93f79@gmail.com>
Date: Thu, 11 Aug 2022 18:31:48 +0300
Cc: internals@lists.php.net
Content-Transfer-Encoding: quoted-printable
Message-ID: <0EEBD1D1-3F49-403C-86AB-8BE456C374A8@gmail.com>
References: <CABigaAWAMfjTh9FBhu-SQRfu9_pgqt5pp7uj4kmNg0QmXbnS-Q@mail.gmail.com>
 <62f48769.250a0220.37387.53b5SMTPIN_ADDED_MISSING@mx.google.com>
 <01D4987C-FD37-4BD2-A1AC-DD10F808F248@gmail.com>
 <b814dad0-a15b-a40c-4c39-3300a7f93f79@gmail.com>
To: Rowan Tommins <rowan.collins@gmail.com>
Subject: Re: [PHP-DEV] [Concept] Extension methods
From: autaut03@gmail.com (Alex Wells)



> On 11 Aug 2022, at 18:10, Rowan Tommins <rowan.collins@gmail.com> =
wrote:
>=20
> On 11/08/2022 10:03, Alex Wells wrote:
>> You could argue the problem is that all of these are single-liners, =
so here are the same examples, but multiline formatted:
>=20
>=20
> When people talk about avoiding one-liners, they're not just talking =
about whitespace, but other refactoring. For example, introducing =
intermediate variables:
>=20
> $fileNameComponents =3D explode('_', $file->getName() );
> $slicedComponents =3D array_slice($fileNameComponents, 4);
> // (most likely there's a better variable name, which would explain =
*why* we're ignoring those components)
> $className =3D Str::studly( implode('_', $slicedComponents) );
>=20
> Or adding additional helper functions:
>=20
> $fileNameComponents =3D explode('_', $file->getName() );
> $slicedComponents =3D array_slice($fileNameComponents, 4);
> $className =3D Str::studlyFromArray( $slicedComponents );
>=20
> Or even, since "Str::studly" probably calls explode() internally =
anyway:
>=20
> $className =3D Str::studlyWithSlice( $file->getName(), 4 );
>=20

I agree that this is a solution for many cases. However, the goal of the =
comparison was to show reduced cognitive complexity, which I don=E2=80=99t=
 believe is what was achieved by splitting a simple expression into =
mulitple lines with multiple variables. It gets progressively harder to =
=E2=80=9Cscan through=E2=80=9D if you=E2=80=99re just trying to get a =
global picture of what=E2=80=99s happening and not specifically =
understand why these lines exist and what they=E2=80=99re doing. =
Sometimes you just need a neat one-liner and that=E2=80=99s enough :)

Besides, variables are statements, making these a statement list, not an =
expression, meaning they can=E2=80=99t be used as one in an arrow =
function or a throw expression.=