Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118414
Message-ID: <b814dad0-a15b-a40c-4c39-3300a7f93f79@gmail.com>
Date: Thu, 11 Aug 2022 16:10:28 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.12.0
Content-Language: en-GB
To: internals@lists.php.net
References: <CABigaAWAMfjTh9FBhu-SQRfu9_pgqt5pp7uj4kmNg0QmXbnS-Q@mail.gmail.com>
 <62f48769.250a0220.37387.53b5SMTPIN_ADDED_MISSING@mx.google.com>
 <01D4987C-FD37-4BD2-A1AC-DD10F808F248@gmail.com>
In-Reply-To: <01D4987C-FD37-4BD2-A1AC-DD10F808F248@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [Concept] Extension methods
From: rowan.collins@gmail.com (Rowan Tommins)

On 11/08/2022 10:03, Alex Wells wrote:
> You could argue the problem is that all of these are single-liners, so here are the same examples, but multiline formatted:


When people talk about avoiding one-liners, they're not just talking 
about whitespace, but other refactoring. For example, introducing 
intermediate variables:

$fileNameComponents = explode('_', $file->getName() );
$slicedComponents = array_slice($fileNameComponents, 4);
// (most likely there's a better variable name, which would explain 
*why* we're ignoring those components)
$className = Str::studly( implode('_', $slicedComponents) );

Or adding additional helper functions:

$fileNameComponents = explode('_', $file->getName() );
$slicedComponents = array_slice($fileNameComponents, 4);
$className = Str::studlyFromArray( $slicedComponents );

Or even, since "Str::studly" probably calls explode() internally anyway:

$className = Str::studlyWithSlice( $file->getName(), 4 );


 >> On 11 Aug 2022, at 07:36, Paul Crovella <paul.crovella@gmail.com> wrote:
 >>
 >> An extension method would shift a single argument from inside 
parentheses to the left of the function name. It just moves it. I don't 
see any impact here.
 >
 > It doesn’t move it, it removes it. You’re technically not passing 
that value as an argument anymore anywhere in your code, your value 
becomes the implicit
 > expression you’re working with. That becomes even more obvious when 
multiple method calls are chained and don’t need to pass it into every 
function call.

I think what Paul means is that "$foo->bar($baz)" and "bar($foo, $baz)" 
have the same "words" - the "$foo" is there in both cases, just in 
different positions. The same is true of nesting vs chaining: 
"$foo->bar()->baz()" has the same "words" as "baz( bar( $foo ) )",  just 
in a different order.

I do agree that the left-to-right order is nicer to read than the nested 
version, but that's largely opinion - it's not actually any shorter.


Regards,

-- 
Rowan Tommins
[IMSoP]