Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118387
Feedback-ID: i835c46d5:Fastmail
User-Agent: Cyrus-JMAP/3.7.0-alpha0-758-ge0d20a54e1-fm-20220729.001-ge0d20a54
Mime-Version: 1.0
Message-ID: <6a52a2bc-a6ec-4d69-bc77-4c4b48f63a29@www.fastmail.com>
In-Reply-To: <6576371A-9C18-4BC4-ADA6-8F364208BF01@newclarity.net>
References: <ec4bc6e5-39ac-4a36-9d63-cca8dc6a29a6@www.fastmail.com>
 <6576371A-9C18-4BC4-ADA6-8F364208BF01@newclarity.net>
Date: Mon, 08 Aug 2022 11:12:16 +0100
To: =?UTF-8?Q?Bj=C3=B6rn_Larsson?= <internals@lists.php.net>
Content-Type: multipart/alternative;
 boundary=dcee18865e2c4702acbad4004a651003
Subject: Re: [PHP-DEV] [RFC] Asymmetric visibility
From: php@ollie.codes ("Ollie Read")

--dcee18865e2c4702acbad4004a651003
Content-Type: text/plain

On Mon, Aug 8, 2022, at 3:54 AM, Mike Schinkel wrote:
> 3.) I have concerns about the proposed methods isProtectedSet() and isPrivateSet().  
> 
> These names feels like we are asking if some thing "Set" is "Protected" or "Private" where no such "thing" exists in this context.  
> 
> In other words it reads as if you are asking "Is it a *protected* Set?" or "Is it a *private* Set?"  Such naming also does not relate to the Property itself which is what the prefix verb "is" is acting on.
> 
> I would propose instead we consider the following are these instead would be asking the *ability* to "Set" the Property is "Protected" or "Private" where The Property is again what the prefix verb "is" is acting on:
> 
> isSetProtected()
> isSetPrivate()
> isGetProtected(), and
> isGetPrivate()

I feel almost as if we shouldn't pollute ReflectionProperty with these additional methods but should instead have something like ReflectionAsymmetricProperty, which would in turn extend ReflectionProperty. 

I guess it depends on how it's handled. If all property handling is updated so that "public int $number" is identical to "public:get public:set int $number", there's no issue, but if we treat those with separate visibilities to be additional, it probably makes sense to be somewhat separate.

While isGetProtected() is technically false for "public int $number", if it's not inferred, it's semantically incorrect. A good example of this is ReflectionMethod::getPrototype, which throws an exception if there's no prototype. Although this is somewhat bizarre, it is at least a thing we do.

---
Best Regards,
*Ollie Read*

--dcee18865e2c4702acbad4004a651003--