Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118371
Message-ID: <578bd2ba-1594-fa0b-0f8b-3734af1f0383@gmail.com>
Date: Sun, 7 Aug 2022 21:38:45 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Content-Language: en-GB
To: internals@lists.php.net
References: <ec4bc6e5-39ac-4a36-9d63-cca8dc6a29a6@www.fastmail.com>
 <CABdc3WqQ-kLTa3C=61_=yW-yJZuP2p_QW1TNe12WuHHur7aHng@mail.gmail.com>
 <e122e44f-550e-4089-8100-a27df9f8c9fa@www.fastmail.com>
 <CAKxcST_Mu3qDKKLgtsBBVAm=6mLirhjZ-88f+jjWeNhWyzO16A@mail.gmail.com>
 <A78DA1F7-1F74-4A94-962C-0EA5979431AD@gmail.com>
 <CANS-=pfq1Q+aK6CWTGKpiSH_M4PABQwb-65HqznDw_xzoDM8+Q@mail.gmail.com>
In-Reply-To: <CANS-=pfq1Q+aK6CWTGKpiSH_M4PABQwb-65HqznDw_xzoDM8+Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC] Asymmetric visibility
From: rowan.collins@gmail.com (Rowan Tommins)

On 07/08/2022 11:54, Lynn wrote:
> Reading "public private", "public protected", or "protected private" 
> reads really weird `public private(set) static self $property`.


Interesting, it seems that you've unconsciously broken it up as "public 
private" followed by "(set)", rather than "public" followed by 
"private(set)". Perhaps it's because of the position of the parentheses, 
which do feel awkward to me at first glance. Would it read more 
naturally to you with different punctuation?

public (private set) static self $property;

Or:

(public; private set) static self $property;

Or:

public private-set static self $property;



On 05/08/2022 19:08, Matthew Weier O'Phinney wrote:
> I'm wondering if this sort of behavior could be indicated via attributes
> instead? Something like `#[PropertySetBehavior(PROPERTY_SET_PRIVATE)]`.
> Attributes have the benefit of being separate from the property
> declaration, arguably more readable (one per line), and composable.


Attributes are no more intrinsically "separate" or "one per line" than 
keywords; the following would be perfectly valid with the RFC's proposed 
syntax:

class Foo {
    public private(set)
        static int|string $id;
}

And the following would be valid with an attribute like you suggest:

class Foo {
    #[PropertySetBehavior(PROPERTY_SET_PRIVATE)] public static 
int|string $id;
}

Even a shorter attribute name would have the extra punctuation, and the 
restriction that it comes before the normal visibility keyword:

class Foo {
    #[PrivateSet] public static int|string $id;
}


Regards,

-- 
Rowan Tommins
[IMSoP]