Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118368
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\))
In-Reply-To: <ec4bc6e5-39ac-4a36-9d63-cca8dc6a29a6@www.fastmail.com>
Date: Sun, 7 Aug 2022 20:58:25 +0200
Cc: php internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <01507B32-31B2-42B6-B35E-78C8E796648E@gmail.com>
References: <ec4bc6e5-39ac-4a36-9d63-cca8dc6a29a6@www.fastmail.com>
To: Larry Garfield <larry@garfieldtech.com>
Subject: Re: [PHP-DEV] [RFC] Asymmetric visibility
From: claude.pache@gmail.com (Claude Pache)



> Le 5 ao=C3=BBt 2022 =C3=A0 19:08, Larry Garfield =
<larry@garfieldtech.com> a =C3=A9crit :
>=20
> Ilija Tovilo and I are happy to present the first new RFC for PHP 8.3: =
Asymmetric Visibility.
>=20
> https://wiki.php.net/rfc/asymmetric-visibility
>=20
> Details are in the RFC, but it's largely a copy of Swift's support for =
the same.
>=20
> --=20
>  Larry Garfield
>  larry@garfieldtech.com
>=20

Hi,

I like the RFC, and in particular allowing property visibility to remain =
orthogonal to property accessors.

There are few missing details in the RFC (which is otherwise good):

1. Are static properties supported?

2. What about properties that are overridden/redeclared in a subclass? =
Given that extending the visibility is generally allowed:

```php
class A {=20
	protected int $x;
}
class B extends A {
	public int $x; // ok
}
```

I expect that the following should be allowed as well:

```php
class A {=20
	public protected(set) int $x;
}
class B extends A {
	public int $x; // ok
}
```

On the other hand, I expect that the two following cases should *not* be =
allowed, because it would break encapsulation of class A:

```php
class A {=20
	public private(set) int $x;
}
class B extends A {
	public int $x; // error: cannot change a private property to =
public (or protected)
}
```

and:

```php
class A {=20
	public private(set) int $x;
}
class B extends A {
	public private(set) int $x; // error: cannot make a private =
property in A as private in B
}
```

=E2=80=94Claude