Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118334
MIME-Version: 1.0
References: <CANMwmbPkDLX4zXDNKh+zchgMxyGUdzSXkKO6eDgE0FPDR1Ezdg@mail.gmail.com>
 <CAF+90c_=uZFNQjTJtGoAUThUqaEBSq0K-ZMTsHdU5J+oM+pTiQ@mail.gmail.com>
 <CA+p1FabMwTGoJuf_Q6Fb+7HyZsKeOiZr88479GqEigu-KuMA7A@mail.gmail.com>
 <CADK1yXLdEJYq1ExFqbjCmbC70dOpjhSH-C9-q=_QnpUDs7vnRA@mail.gmail.com>
 <CANMwmbOYR=B87TCYeu26WwAfepXs3KZK2jAhd3HyT3OhgTm9mw@mail.gmail.com>
 <CAKxcST_Pf2-gS9gumWzi1SSgXkZ_=hONHDBAQ4jDm=GO0URp8Q@mail.gmail.com> <CANMwmbN3N0t=ZVDDRZukeXLHJKSMiibN5RL_e1hF6_w84XTN=A@mail.gmail.com>
In-Reply-To: <CANMwmbN3N0t=ZVDDRZukeXLHJKSMiibN5RL_e1hF6_w84XTN=A@mail.gmail.com>
Date: Sun, 31 Jul 2022 22:16:42 -0400
Message-ID: <CA+sv8zBd=ZBESfD8MvRpiorUM-gv-9EQ-uvjSKKsnigvfsaxag@mail.gmail.com>
To: juan carlos morales <dev.juan.morales@gmail.com>
Cc: Paul Dragoonis <dragoonis@gmail.com>, Deleu <deleugyn@gmail.com>, 
	David Gebler <davidgebler@gmail.com>, Nikita Popov <nikita.ppv@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000e8271805e524972a"
Subject: Re: [PHP-DEV] RFC Idea - is_json - looking for feedback
From: jrbasso@gmail.com (Juan Basso)

--000000000000e8271805e524972a
Content-Type: text/plain; charset="UTF-8"

I think the arguments are good enough for the RFC. However, I would like to
propose using a different API. Instead of creating a new global function
that could conflict with existing applications, use filter_var validations
since it is basically a validation. You can do something like
filter_var($possibleJSON, FILTER_VALIDATE_JSON). Over time, if there is a
need for extra parameters you can still use the filter_var flags or options
(3rd parameter) to indicate if you want just JSON Object, JSON Array, JSON
scalar, etc.

Juan Basso

On Sun, Jul 31, 2022 at 3:46 PM juan carlos morales <
dev.juan.morales@gmail.com> wrote:

> Hi Juan,
> >
> > Thanks for your efforts, and examples.
> >
> > You are solving a common use case, in frameworks, libs, and general
> > userland.
> >
> > This much needed function will see good perf/memory improvements once
> > adoption of is_json() hits popular libs and frameworks.
> >
> > I will be voting in favor of this addition, subject to reviewing the
> > implementation and full RFC.
> >
> > Thanks for the effort. Looking forward to seeing it merged :)
> >
> > Many thanks,
> > Paul Dragoonis
> >
> >
> >
> >>
> Hello Paul, and sorry, I totally missed your message, thanks for the kind
> feedback, you made my day.
>
> So, if I get it correctly, I have green light to move on with the RFC
> process right? so ... I will move on. Once everything is done I will ping
> again.
>
> Regards,
>
> Juan
>
> PD: I had to re-send the message as it was too long, ... I am using a
> mailing list for the first time ever :)
>

--000000000000e8271805e524972a--