Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118319
MIME-Version: 1.0
References: <CANMwmbPkDLX4zXDNKh+zchgMxyGUdzSXkKO6eDgE0FPDR1Ezdg@mail.gmail.com>
 <0d5ad8ab-aa7a-c37c-2d26-17e6b6953b4e@alec.pl> <5426361E-43A2-4B3D-9042-57FAD6F1FF0D@woofle.net>
In-Reply-To: <5426361E-43A2-4B3D-9042-57FAD6F1FF0D@woofle.net>
Date: Sat, 30 Jul 2022 08:44:17 +0200
Message-ID: <CANMwmbOSSsg-qZfZWLbuppqn0Fk89h4aSkPPWSqDdxprVqxCWQ@mail.gmail.com>
To: Dusk <dusk@woofle.net>
Cc: Aleksander Machniak <alec@alec.pl>, PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000001ebcca05e5001946"
Subject: Re: [PHP-DEV] RFC Idea - is_json - looking for feedback
From: dev.juan.morales@gmail.com (juan carlos morales)

--0000000000001ebcca05e5001946
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

El s=C3=A1b, 30 jul 2022 a las 8:30, Dusk (<dusk@woofle.net>) escribi=C3=B3=
:

> On Jul 29, 2022, at 23:05, Aleksander Machniak <alec@alec.pl> wrote:
> > json_decode() has $depth argument, I think is_json() probably also
> should. And I'm not sure about JSON_INVALID_UTF8_IGNORE flag.
> >
> > My point is that if you use these with json_decode() you might also nee=
d
> to use these with is_json()
>
> How about if validation were a flag to json_decode() -- perhaps
> JSON_VALIDATE_ONLY -- which made it return a placeholder value like true
> instead of the decoded structure? (It can't return null on success; that'=
s
> used for errors if JSON_THROW_ON_ERROR isn't set.)
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>
>

I thought about that too, and yes can also be a valid approach that would
not interfeer with my development.

What I personally dont like about that approach is that a developer is able
to specify flags that are related to exclusively with result generation,
and when they get mixed with JSON_VALIDATE_ONLY would not make sense. for
example:

json_decode($jsonStringHere, false, 512, JSON_BIGINT_AS_STRING |
JSON_INVALID_UTF8_SUBSTITUTE | JSON_OBJECT_AS_ARRAY | JSON_THROW_ON_ERROR |
JSON_VALIDATE_ONLY);

So the end result, is not clear by reading the line itself, I mean , the
mechanism (of having another constant in json_decode()) is not enough to
make the function self-expressive.

--0000000000001ebcca05e5001946--