Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118315
MIME-Version: 1.0
References: <CANMwmbPkDLX4zXDNKh+zchgMxyGUdzSXkKO6eDgE0FPDR1Ezdg@mail.gmail.com>
In-Reply-To: <CANMwmbPkDLX4zXDNKh+zchgMxyGUdzSXkKO6eDgE0FPDR1Ezdg@mail.gmail.com>
Date: Fri, 29 Jul 2022 18:50:08 -0700
Message-ID: <CAMrTa2FpTxD9k+B0WUtR=8qYxjVJjUgVwGHf76dH2FkwjPUdWw@mail.gmail.com>
To: juan carlos morales <dev.juan.morales@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000024ac8d05e4fbfdd5"
Subject: Re: [PHP-DEV] RFC Idea - is_json - looking for feedback
From: jordan.ledoux@gmail.com (Jordan LeDoux)

--00000000000024ac8d05e4fbfdd5
Content-Type: text/plain; charset="UTF-8"

On Fri, Jul 29, 2022 at 7:27 AM juan carlos morales <
dev.juan.morales@gmail.com> wrote:

> # Why this function ?
>
> At the moment the only way to determine if a JSON-string is valid we have
> to execute the json_decode() function.
>
> The drawback about this, is that json_decode() generates an in memory an
> object/array (depending on parameters) while parsing the string; this leads
> to a memory usage that is not needed (because we use memory for creating
> the object/array) and also can cause an error for reaching the memory-limit
> of the php process.
>
> Sometimes we just need to know is the string is a valid json or not, and
> nothing else.
>

You say that you have a first-pass at the implementation done. I'd be
curious to see it. My initial thought was that in order to validate the
string, you likely need to allocate extra memory as part of the validation
that depends on the string size. You'd definitely save the overhead of a
ZVAL, but for such an object that overhead is likely negligible.

So I guess my question would be: in the actual implementation that lands,
how much memory would this actually save compared to json_decode()? This
seems like it would make the RFC tricky, as the purported benefit of the
RFC depends very tightly on the implementation that lands.

Jordan

--00000000000024ac8d05e4fbfdd5--