Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118313
MIME-Version: 1.0
References: <CANMwmbPkDLX4zXDNKh+zchgMxyGUdzSXkKO6eDgE0FPDR1Ezdg@mail.gmail.com>
 <CABdc3WqJRw3g8_b7f5eA08p8BbQOPurpUopBo+23ta0SehtjQQ@mail.gmail.com>
In-Reply-To: <CABdc3WqJRw3g8_b7f5eA08p8BbQOPurpUopBo+23ta0SehtjQQ@mail.gmail.com>
Date: Fri, 29 Jul 2022 17:17:39 -0300
Message-ID: <CAEsg9X1A8isBi96t33=+MjoVWA+WqSRO03=hiRp4fd28h+Vw7A@mail.gmail.com>
To: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000391c2c05e4f75816"
Subject: Re: [PHP-DEV] RFC Idea - is_json - looking for feedback
From: david.proweb@gmail.com (David Rodrigues)

--000000000000391c2c05e4f75816
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

I was about to say NO, but after being completely your argument, the idea
makes sense.

Initially I thought about using json_decode() with error capture, but the
idea that it would overload memory makes perfect sense, compared to a
simple structure analysis, if that is indeed the user's intention. The
performance would also be absurdly better.

What worries me above is the misuse of the function, like checking if
is_json() =3D=3D=3D true and using json_decode() right after. However, I be=
lieve
this can be easily optimized by the engine itself.

My vote is YES.


Atenciosamente,
David Rodrigues


Em sex., 29 de jul. de 2022 =C3=A0s 16:32, Micha=C5=82 Marcin Brzuchalski <
michal.brzuchalski@gmail.com> escreveu:

> Hi Juan,
>
> pt., 29 lip 2022, 16:26 u=C5=BCytkownik juan carlos morales <
> dev.juan.morales@gmail.com> napisa=C5=82:
>
> > I am following the RFC guideline for the first time. (
> > https://wiki.php.net/rfc/howto)
> >
> > As suggested there, I am here to get a feeling from you, regarding the
> > following RFC for PHP.
> >
> > # Change (draft):
> >
> > New function in php called like:
> >
> > is_json(string $string): bool
> >
> > ## Description
> > ### Parameters
> > string $string -> string to find out if is a valid JSON or not
> >
> > ### Return
> > Returns a bool. The function is capable to determine if the passed stri=
ng
> > is a valid JSON (true) or not (false).
> >
> > # Why this function ?
> >
> > At the moment the only way to determine if a JSON-string is valid we ha=
ve
> > to execute the json_decode() function.
> >
> > The drawback about this, is that json_decode() generates an in memory a=
n
> > object/array (depending on parameters) while parsing the string; this
> leads
> > to a memory usage that is not needed (because we use memory for creatin=
g
> > the object/array) and also can cause an error for reaching the
> memory-limit
> > of the php process.
> >
>
> Personally I'd vote NO.
>
> Cheers,
> Micha=C5=82 Marcin Brzuchalski
>
> >
>

--000000000000391c2c05e4f75816--