Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118290
MIME-Version: 1.0
Date: Wed, 20 Jul 2022 23:24:12 +0900
Message-ID: <CABTDVhDnC2oBqTf5O+8KY-dAUKZnWVGsRWoHY0oYEv5aj5Z+9g@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000095ef3f05e43d5b08"
Subject: Random Extension 5.x needs follow-up
From: zeriyoshi@gmail.com (Go Kudo)

--00000000000095ef3f05e43d5b08
Content-Type: text/plain; charset="UTF-8"

Hi Internals.

The Random Extension 5.x and Random Extension Improvement RFCs have been
passed and recently merged into the master branch. However, the proposal is
still problematic and implementation fixes are needed.

Currently, the mt_rand() function is overloading its arguments, and I have
designed a Randomizer::getInt() signature based on this. However, argument
overloading has several problems, including reflection, and is now not
recommended.

I wish I had been aware of it during the RFC proposal, but that did not
happen.

To solve the problem, I thought of separating the argumentless
`Randomizer::getInt()` as `Randomizer::nextInt()`. `Randomizer::getInt()`
must require `int $min, int $max` arguments.

I have received support for this proposal from several people, but there
will be a discrepancy between the RFC and the implementation.

I believe this should be corrected to avoid future BC Break, what do you
think about this?

Discussions:
- https://externals.io/message/118163#118269
- https://github.com/php/php-src/pull/8094/files#r919693108 (just scroll a
little please)

Fix PR: https://github.com/php/php-src/pull/9057

Best Regards
Go Kudo

--00000000000095ef3f05e43d5b08--