Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118288
Message-ID: <8f17e49f-2c2b-2aa5-2184-e12acac175c4@bastelstu.be>
Date: Tue, 19 Jul 2022 22:22:04 +0200
MIME-Version: 1.0
Content-Language: en-US
To: Go Kudo <zeriyoshi@gmail.com>, Go Kudo <g-kudo@colopl.co.jp>,
 PHP internals <internals@lists.php.net>
References: <CAMs36Hf_PsPnCjwxTMvLP10cRU9WheLKoYnr7+i91j39RkmNNA@mail.gmail.com>
 <CABTDVhA_4jmjxbWe__gDmhE4mTWRhZQ5UURE_aKO0TKF3ncdkQ@mail.gmail.com>
In-Reply-To: <CABTDVhA_4jmjxbWe__gDmhE4mTWRhZQ5UURE_aKO0TKF3ncdkQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [VOTE] Random Extension Improvement
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 7/16/22 08:11, Go Kudo wrote:
> However, as pointed out in the PR, there are still areas that need to be
> improved and corrected.
> 
> First of all, overloading of `getInt()` should be stopped. This is due to
> the fact that the signature of the `mt_rand()` function is still used, but
> it was pointed out that no new implementation should be made.
> 
> https://github.com/php/php-src/pull/8094/files#r919693108
> 
> Second, there is an issue regarding the handling of header files for
> compatibility. This was left in because it was considered necessary in
> previous discussions, but it has been suggested that it is unnecessary. I
> too would like to remove it if possible.
> 
> https://github.com/php/php-src/pull/8094/files#r917308676
> 
> However, if you try to make this change by creating an RFC as usual, you
> are already out of time.
> 
> I am really confused and don't really know what to do about this.
> 
> Can anyone give me some good ideas?

For those following along, the follow-up PR is here:

https://github.com/php/php-src/pull/9052

Best regards
Tim Düsterhus