Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:118272 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 52736 invoked from network); 18 Jul 2022 09:23:07 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 18 Jul 2022 09:23:07 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 6AD66180505 for ; Mon, 18 Jul 2022 04:19:08 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com [209.85.219.176]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Mon, 18 Jul 2022 04:19:07 -0700 (PDT) Received: by mail-yb1-f176.google.com with SMTP id h62so20096619ybb.11 for ; Mon, 18 Jul 2022 04:19:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5TKAPBDBE8bjPKRObOLIAx4fNC6n7JrCXqaIb0SWPW0=; b=CQrpXQSAWPD4G3sIYTuxParUNztUPKcgUn7ArnwahNSfykzicnwzey4fg7weorliAD zC+HhKLBp5q7Yru+OyhT7zaXsPvrIzodKfPtIbB0p7vN1e1VaVAfsshCpmqCNDPZFh/y IpbPa1CczEFqrkC9swKzYdbrNVAO5AJ3i2wCE1IeThBC2AHQxP8EEw1rwf7znsF65/6p XUMkxmosOsguTzfGx7xItlApEDneJ1THQYcJnlkyyLL3MbSjF8v3QT9+vGJXdL1/mgCZ uyXZDOo7aqnhKSqLdKfNZREEAuSFuZoF+KJ+hQvcGsljxf6zfDt0a6xlGGLtkRAKndtP RDnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5TKAPBDBE8bjPKRObOLIAx4fNC6n7JrCXqaIb0SWPW0=; b=uNk/ONtEIGwr18JLs3ojyuQKw2JZvCOSkU18sP5kZy1j02x94s5+Al4VFt4sTUVy7t HjjxA21EHo7xwyluoZoDy6ZYqQmMnvfy5NoH+5zk+i5GSHOtzUUloCfaXe/i77j+bkHq 7Y1Yn/4ijyHjsmq7q1/rOQ6S5OJ6ODW/biYee+AU2Djot/wu1TFQ1vRJhKzYMTcwJqNT XXrt4GbkNPZThRcXhvWwcW0nASbCOu1NigsyG1vc1gI6GJeCSC8VphiDtFFs1wnm7Gme 524Ea1hv+NauXI4pF8dTMfj2jOqHODS/fOKgf2W5MnddigLQLoCnvEClDoeYCCmgIHZb gByg== X-Gm-Message-State: AJIora+0PISUsVM8NgwhgZbFuZLSMv8ttALym9H5eL79D/SHfGexh8wY M2wSmuA+8ROSqJdwg+9DOF9aqr6Ep0JPVh+y8w== X-Google-Smtp-Source: AGRyM1vdeMVpXyFzOuwABekZnumWbAA2PX7X8z+OKx9TN5UD3XxrjBG1kZuBM/Wm0OaP6GmOStia9runOwIp7aGcWD8= X-Received: by 2002:a25:805:0:b0:670:4237:cddf with SMTP id 5-20020a250805000000b006704237cddfmr4769979ybi.9.1658143147257; Mon, 18 Jul 2022 04:19:07 -0700 (PDT) MIME-Version: 1.0 References: <5ECCFE96-8C0E-428B-9C18-F30B724BD8D5@gmail.com> In-Reply-To: Date: Mon, 18 Jul 2022 13:18:56 +0200 Message-ID: To: Go Kudo Cc: Claude Pache , PHP internals Content-Type: text/plain; charset="UTF-8" Subject: Re: [PHP-DEV] [VOTE] Random Extension Improvement From: guilliam.xavier@gmail.com (Guilliam Xavier) > For example, what about the `$binaryString` argument name? I would recommend to either keep `$string` (conservative) or rename it to `$bytes` (consistent with the new function name) [I interpret the RFCs as the former, but the implementation is currently as the latter]. About your other mail, I too like the idea to split `getInt(int $min = UNKNOWN, int $max = UNKNOWN)` into distinct `nextInt()` and `getInt(int $min, int $max)` [in a subsequent PR, IIUC]. Regards, -- Guilliam Xavier