Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118266
MIME-Version: 1.0
References: <CAMs36Hf_PsPnCjwxTMvLP10cRU9WheLKoYnr7+i91j39RkmNNA@mail.gmail.com>
 <CAMs36HevSn_=OzBB9GmFYeRu87kbKiOOAHeCuug2jhf6kzmMjQ@mail.gmail.com>
 <d39747f2-4127-208e-6d14-f6fed89872ef@bastelstu.be> <f42234ed-5fb0-c879-ac72-a6897379bbed@bastelstu.be>
 <CAMs36Hfnhrh_wKEU77oGpcBuJmGy1UaRefJdizafFxuajx2eog@mail.gmail.com>
 <CAC5V6ghyqHXbWuAoGfTjJyYNUu+kDcRY9nRHfN7=UybV5BXtSA@mail.gmail.com> <5ECCFE96-8C0E-428B-9C18-F30B724BD8D5@gmail.com>
In-Reply-To: <5ECCFE96-8C0E-428B-9C18-F30B724BD8D5@gmail.com>
Date: Sat, 16 Jul 2022 01:02:02 +0900
Message-ID: <CABTDVhAwgQpXVoKDD3PiG-6zdFBOe+BqkUuJftm_=3_dxahGVw@mail.gmail.com>
To: Claude Pache <claude.pache@gmail.com>, Guilliam Xavier <guilliam.xavier@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000003b44d405e3da24e9"
Subject: Re: [PHP-DEV] [VOTE] Random Extension Improvement
From: zeriyoshi@gmail.com (Go Kudo)

--0000000000003b44d405e3da24e9
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

2022=E5=B9=B47=E6=9C=8814=E6=97=A5(=E6=9C=A8) 16:14 Claude Pache <claude.pa=
che@gmail.com>:

>
>
> > Le 14 juil. 2022 =C3=A0 06:32, Guilliam Xavier <guilliam.xavier@gmail.c=
om> a
> =C3=A9crit :
> >
> > On Thursday, July 14, 2022, Go Kudo <g-kudo@colopl.co.jp> wrote:
> >
> >> 2022=E5=B9=B47=E6=9C=8813=E6=97=A5(=E6=B0=B4) 1:10 Tim D=C3=BCsterhus =
<tim@bastelstu.be>:
> >>
> >>> Hi
> >>>
> >>> On 7/12/22 18:04, Tim D=C3=BCsterhus wrote:
> >>>> I also think that both '$string' and '$binary' are appropriate
> parameter
> >>>> names in this case, so particular preference from my side.
> >>>
> >>> Sorry for the follow-up, there's two mistakes in that sentence. It
> >>> should read:
> >>>
> >>> I also think that both '$string' and **'$bytes'** are appropriate
> >>> parameter names in this case, so **no** particular preference from my
> >>> side.
> >>>
> >>> Best regards
> >>> Tim D=C3=BCsterhus
> >>>
> >>
> >> Hi
> >>
> >> I agree with you. I will change the parameter name from `$string` to
> >> `$bytes` as I don't see any problem.
> >>
> >> I will try to explain the changes more rigorously in future proposals.
> >> Thank you.
> >>
> >> Regards,
> >> Go Kudo
> >>
> >
> > Hi,
> >
> > I was waiting for more opinions but... so here's mine:
> >
> > I would prefer to keep "$string", as [that's how I read the RFCs, and]
> when
> > calling e.g. shuffleBytes('foobar') I don't feel like I'm passing "byte=
s"
> > (or "a binary") but a string (to be shuffled byte-wise rather than
> > character-wise or codepoint-wise, but that's from the function, not the
> > argument)...
> > Granted, not compelling, and probably won't matter in practice, but hey
> ;)
> >
> > Regards
> >
> > PS: sent from mobile
> >
> >
> > --
> > Guilliam Xavier
>
> I agree with Guilliam: this function is about =C2=ABshuffling the bytes o=
f the
> given string=C2=BB (as opposed to, say, =C2=ABarray of ints=C2=BB)
>
> As precedent, there are `bin2hex($string)` and `md5($string)`, which are
> unambiguously working with bytes from data given in the form of string,
> where =C2=ABstring=C2=BB is a PHP type, which can hold data that is not n=
ecessarily
> UTF-8-encoded or Shift-JIS-encoded text.
>
> =E2=80=94Claude
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>
>
Thanks for the input. This is certainly something to consider.

For example, what about the `$binaryString` argument name? I think it is
clearer. I have adopted this as the name of the internal API:
`php_binary_string_shuffle()`.

As stated in the GitHub PR, this implementation probably requires
additional changes. After voting on the current RFC is complete, we will
again send an email to the ML.

Regards,
Go Kudo

--0000000000003b44d405e3da24e9--