Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118264
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\))
In-Reply-To: <CAC5V6ghyqHXbWuAoGfTjJyYNUu+kDcRY9nRHfN7=UybV5BXtSA@mail.gmail.com>
Date: Thu, 14 Jul 2022 09:13:36 +0200
Cc: Go Kudo <g-kudo@colopl.co.jp>,
 =?utf-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>,
 "internals@lists.php.net" <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <5ECCFE96-8C0E-428B-9C18-F30B724BD8D5@gmail.com>
References: <CAMs36Hf_PsPnCjwxTMvLP10cRU9WheLKoYnr7+i91j39RkmNNA@mail.gmail.com>
 <CAMs36HevSn_=OzBB9GmFYeRu87kbKiOOAHeCuug2jhf6kzmMjQ@mail.gmail.com>
 <d39747f2-4127-208e-6d14-f6fed89872ef@bastelstu.be>
 <f42234ed-5fb0-c879-ac72-a6897379bbed@bastelstu.be>
 <CAMs36Hfnhrh_wKEU77oGpcBuJmGy1UaRefJdizafFxuajx2eog@mail.gmail.com>
 <CAC5V6ghyqHXbWuAoGfTjJyYNUu+kDcRY9nRHfN7=UybV5BXtSA@mail.gmail.com>
To: Guilliam Xavier <guilliam.xavier@gmail.com>
Subject: Re: [PHP-DEV] [VOTE] Random Extension Improvement
From: claude.pache@gmail.com (Claude Pache)



> Le 14 juil. 2022 =C3=A0 06:32, Guilliam Xavier =
<guilliam.xavier@gmail.com> a =C3=A9crit :
>=20
> On Thursday, July 14, 2022, Go Kudo <g-kudo@colopl.co.jp> wrote:
>=20
>> 2022=E5=B9=B47=E6=9C=8813=E6=97=A5(=E6=B0=B4) 1:10 Tim D=C3=BCsterhus =
<tim@bastelstu.be>:
>>=20
>>> Hi
>>>=20
>>> On 7/12/22 18:04, Tim D=C3=BCsterhus wrote:
>>>> I also think that both '$string' and '$binary' are appropriate =
parameter
>>>> names in this case, so particular preference from my side.
>>>=20
>>> Sorry for the follow-up, there's two mistakes in that sentence. It
>>> should read:
>>>=20
>>> I also think that both '$string' and **'$bytes'** are appropriate
>>> parameter names in this case, so **no** particular preference from =
my
>>> side.
>>>=20
>>> Best regards
>>> Tim D=C3=BCsterhus
>>>=20
>>=20
>> Hi
>>=20
>> I agree with you. I will change the parameter name from `$string` to
>> `$bytes` as I don't see any problem.
>>=20
>> I will try to explain the changes more rigorously in future =
proposals.
>> Thank you.
>>=20
>> Regards,
>> Go Kudo
>>=20
>=20
> Hi,
>=20
> I was waiting for more opinions but... so here's mine:
>=20
> I would prefer to keep "$string", as [that's how I read the RFCs, and] =
when
> calling e.g. shuffleBytes('foobar') I don't feel like I'm passing =
"bytes"
> (or "a binary") but a string (to be shuffled byte-wise rather than
> character-wise or codepoint-wise, but that's from the function, not =
the
> argument)...
> Granted, not compelling, and probably won't matter in practice, but =
hey ;)
>=20
> Regards
>=20
> PS: sent from mobile
>=20
>=20
> --=20
> Guilliam Xavier

I agree with Guilliam: this function is about =C2=ABshuffling the bytes =
of the given string=C2=BB (as opposed to, say, =C2=ABarray of ints=C2=BB)

As precedent, there are `bin2hex($string)` and `md5($string)`, which are =
unambiguously working with bytes from data given in the form of string, =
where =C2=ABstring=C2=BB is a PHP type, which can hold data that is not =
necessarily UTF-8-encoded or Shift-JIS-encoded text.

=E2=80=94Claude