Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118263
MIME-Version: 1.0
In-Reply-To: <CAMs36Hfnhrh_wKEU77oGpcBuJmGy1UaRefJdizafFxuajx2eog@mail.gmail.com>
References: <CAMs36Hf_PsPnCjwxTMvLP10cRU9WheLKoYnr7+i91j39RkmNNA@mail.gmail.com>
 <CAMs36HevSn_=OzBB9GmFYeRu87kbKiOOAHeCuug2jhf6kzmMjQ@mail.gmail.com>
 <d39747f2-4127-208e-6d14-f6fed89872ef@bastelstu.be> <f42234ed-5fb0-c879-ac72-a6897379bbed@bastelstu.be>
 <CAMs36Hfnhrh_wKEU77oGpcBuJmGy1UaRefJdizafFxuajx2eog@mail.gmail.com>
Date: Thu, 14 Jul 2022 06:32:02 +0200
Message-ID: <CAC5V6ghyqHXbWuAoGfTjJyYNUu+kDcRY9nRHfN7=UybV5BXtSA@mail.gmail.com>
To: Go Kudo <g-kudo@colopl.co.jp>
Cc: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000021c6f105e3bc62e4"
Subject: Re: [PHP-DEV] [VOTE] Random Extension Improvement
From: guilliam.xavier@gmail.com (Guilliam Xavier)

--00000000000021c6f105e3bc62e4
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thursday, July 14, 2022, Go Kudo <g-kudo@colopl.co.jp> wrote:

> 2022=E5=B9=B47=E6=9C=8813=E6=97=A5(=E6=B0=B4) 1:10 Tim D=C3=BCsterhus <ti=
m@bastelstu.be>:
>
>> Hi
>>
>> On 7/12/22 18:04, Tim D=C3=BCsterhus wrote:
>> > I also think that both '$string' and '$binary' are appropriate paramet=
er
>> > names in this case, so particular preference from my side.
>>
>> Sorry for the follow-up, there's two mistakes in that sentence. It
>> should read:
>>
>> I also think that both '$string' and **'$bytes'** are appropriate
>> parameter names in this case, so **no** particular preference from my
>> side.
>>
>> Best regards
>> Tim D=C3=BCsterhus
>>
>
> Hi
>
> I agree with you. I will change the parameter name from `$string` to
> `$bytes` as I don't see any problem.
>
> I will try to explain the changes more rigorously in future proposals.
> Thank you.
>
> Regards,
> Go Kudo
>

Hi,

I was waiting for more opinions but... so here's mine:

I would prefer to keep "$string", as [that's how I read the RFCs, and] when
calling e.g. shuffleBytes('foobar') I don't feel like I'm passing "bytes"
(or "a binary") but a string (to be shuffled byte-wise rather than
character-wise or codepoint-wise, but that's from the function, not the
argument)...
Granted, not compelling, and probably won't matter in practice, but hey ;)

Regards

PS: sent from mobile


--=20
Guilliam Xavier

--00000000000021c6f105e3bc62e4--