Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118257
Message-ID: <d39747f2-4127-208e-6d14-f6fed89872ef@bastelstu.be>
Date: Tue, 12 Jul 2022 18:04:21 +0200
MIME-Version: 1.0
Content-Language: en-US
To: Go Kudo <g-kudo@colopl.co.jp>, internals@lists.php.net
References: <CAMs36Hf_PsPnCjwxTMvLP10cRU9WheLKoYnr7+i91j39RkmNNA@mail.gmail.com>
 <CAMs36HevSn_=OzBB9GmFYeRu87kbKiOOAHeCuug2jhf6kzmMjQ@mail.gmail.com>
In-Reply-To: <CAMs36HevSn_=OzBB9GmFYeRu87kbKiOOAHeCuug2jhf6kzmMjQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] Re: [VOTE] Random Extension Improvement
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=c3=bcsterhus?=)

Hi

On 7/12/22 14:26, Go Kudo wrote:
> Currently, the renaming of Randomizer::shuffleString() to
> Randomizer::shuffleBytes() seems acceptable.
> 
> I forgot to note the change regarding arguments when I submitted this RFC.
> With this change, the argument was supposed to be changed from `string
> $string` to `string $bytes`.
> 
> - https://github.com/php/php-src/pull/8094#discussion_r916630626
> 
> Is this change acceptable? Or should I keep `string $string`?

I believe if the method name changes, then the parameter names are also 
open for adjustment. Especially in this case of a single parameter 
method where it is unlikely that named parameters are used by the developer.

I also think that both '$string' and '$binary' are appropriate parameter 
names in this case, so particular preference from my side.

Best regards
Tim Düsterhus