Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:118254 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 12395 invoked from network); 12 Jul 2022 11:47:54 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 12 Jul 2022 11:47:54 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 51D9F180543 for ; Tue, 12 Jul 2022 06:42:26 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.2 X-Spam-ASN: AS15169 209.85.128.0/17 X-Spam-Virus: No X-Envelope-From: Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Tue, 12 Jul 2022 06:42:25 -0700 (PDT) Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-31c8a1e9e33so81282577b3.5 for ; Tue, 12 Jul 2022 06:42:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=zEGN6AYxde5YsxamKz7pXZY5Y48ayAnEJ4fj9lETZ2Y=; b=nLfR6nSBYPC8cyifctv+jM/jNNMS5eJ30QDB1R0ufgtvrtUrU51uW18pPwijLgqQmu ZBX1ukk3Cd/SSpByT+6jySr3lYkJLdYHJT7pqlhD/TZkv/a4NDc6uYpTs/oEol+/L2Kq coD3e4q0QS3wfhjEI4sZQXNYYBMLEqBAHZTRcao/dhNeSpnshtrSgHFaxmV9QzcqdQK8 qJps1Z3oWVWrb1fqTyYNC/PSyzK5+EMgKrEaJkr/v2bC7+82EvHsjCN27taqPl0/fQlK Vr1YAZTkJ4lahtLIVTypwzp0TzDv7UDHKqak9+smkN9G0du7nKOqLlQD90/CTpldeUdh b18A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=zEGN6AYxde5YsxamKz7pXZY5Y48ayAnEJ4fj9lETZ2Y=; b=QTRLS3htgXeGfToIL+rP8//bId8ZuqH55etXAimVq5IvTv78WCnCibmM8d0jYsBAB2 7C1Qy5b87hQX6mLUrGPrDXrDUBSdqC6iTfhfqmFAaF3ggCR9DWVg0u1iLQ7+h90xNQ1l mvT149L4PG41fUZ0kApdMdg63CT/RS2AbRSWrf6JaiAUaU43ECtffoeInaXLG/riQC5t HHlvPOykuWrLnscdTUq+ZNyK/qQ/YsBJxkALkuXj8x2wd3wxwIef7xm0GxxCp+MjEHFn 882+K4JSFUNZopbh8rxfrHctaAmg0uYoblKlVyV7eRLkypHTc6WNqWLFcRClMAplJ01B XfYg== X-Gm-Message-State: AJIora/ZQDOTOFGNJjBAI4omCx+pIyVQ1iM8npMvRbt/r5YEfq3ztT/7 xVKaXXl/0nr/6G0MXZuT9oStK1PAfX80R8iE++13oI4skw== X-Google-Smtp-Source: AGRyM1t8hRd7oLtcXBghYWFKuG3ULw0xO8ldV0ZMp2o9DumUep3dZYSxWV9sFZYxHh1Q2zS1gNk6g+m/BuaSQiBbQhQ= X-Received: by 2002:a81:9910:0:b0:31c:8cff:c6a1 with SMTP id q16-20020a819910000000b0031c8cffc6a1mr26209589ywg.424.1657633344894; Tue, 12 Jul 2022 06:42:24 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: Date: Tue, 12 Jul 2022 15:42:13 +0200 Message-ID: To: internals@lists.php.net Content-Type: text/plain; charset="UTF-8" Subject: Re: [PHP-DEV] Re: [VOTE] Random Extension Improvement From: guilliam.xavier@gmail.com (Guilliam Xavier) > > https://wiki.php.net/rfc/random_extension_improvement > > Hi Internals. > > Currently, the renaming of Randomizer::shuffleString() to > Randomizer::shuffleBytes() seems acceptable. > > I forgot to note the change regarding arguments when I submitted this RFC. > With this change, the argument was supposed to be changed from `string > $string` to `string $bytes`. > > - https://github.com/php/php-src/pull/8094#discussion_r916630626 For reference, first was https://github.com/php/php-src/pull/8094/commits/32e83a71eae67fdd822fd12ded5a8c054024a4da#r916058794 > Is this change acceptable? Or should I keep `string $string`?