Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:118252
MIME-Version: 1.0
References: <CAMs36Hf_PsPnCjwxTMvLP10cRU9WheLKoYnr7+i91j39RkmNNA@mail.gmail.com>
In-Reply-To: <CAMs36Hf_PsPnCjwxTMvLP10cRU9WheLKoYnr7+i91j39RkmNNA@mail.gmail.com>
Date: Tue, 12 Jul 2022 21:26:53 +0900
Message-ID: <CAMs36HevSn_=OzBB9GmFYeRu87kbKiOOAHeCuug2jhf6kzmMjQ@mail.gmail.com>
To: internals@lists.php.net
Content-Type: multipart/alternative; boundary="00000000000033cd1905e39ac9b3"
Subject: Re: [VOTE] Random Extension Improvement
From: g-kudo@colopl.co.jp (Go Kudo)

--00000000000033cd1905e39ac9b3
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

2022=E5=B9=B47=E6=9C=883=E6=97=A5(=E6=97=A5) 12:00 Go Kudo <g-kudo@colopl.c=
o.jp>:

> Hello internals.
>
> Voting began on 2022-07-02 03:00:00 (UTC) and will end on 2022-07-16
> 03:00:00 (UTC).
>
> https://wiki.php.net/rfc/random_extension_improvement
>
> Best Regards,
> Go Kudo
>

Hi Internals.

Currently, the renaming of Randomizer::shuffleString() to
Randomizer::shuffleBytes() seems acceptable.

I forgot to note the change regarding arguments when I submitted this RFC.
With this change, the argument was supposed to be changed from `string
$string` to `string $bytes`.

- https://github.com/php/php-src/pull/8094#discussion_r916630626

Is this change acceptable? Or should I keep `string $string`?

Regards,
Go Kudo

--00000000000033cd1905e39ac9b3--